cinereal
ae9994806c
Fixes several correctness bugs primarily around modular services' recent reload/notification options (#535695) and adds compliance coverage to guard them. Fixes: - `lib/services/service.nix`: - the reload-conflict assertion had inverted polarity, so it fired on the default configuration - the `mkIf` guard on `process.reloadCommand` had a misplaced paren, applying `!= null` to the `mkIf` result rather than to the condition - `process.reloadSignal` derives `process.reloadCommand`, so the assertion could not check `reloadCommand != null` -- that fired on every signal-only service. The command is now derived at `mkDefault` priority and the assertion is gated on `options.process.reloadCommand.highestPrio`, firing only when the user also set `reloadCommand` explicitly. - change `notificationProtocol` to a sub-module type - `nixos/modules/system/service/systemd/service.nix`: - `systemd.mainExecReload`'s default ran `escapeSystemdExecArgs` (a list escaper) on the `nullOr str` `process.reloadCommand`; this threw `expected a list but found a string` and would have mangled `$MAINPID`. It now uses `process.reloadCommand` verbatim. - the `Type` default read a non-existent `config.serviceManager.notificationProtocol` instead of `config.notificationProtocol`. Tests: Extend the modular-service compliance suite to guard the above: - Portable (manager-agnostic) eval assertions: `reloadSignal` derives `reloadCommand`, the conflict assertion does not fire on signal-only services but does when both are set explicitly, and `notificationProtocol.systemd`/`.s6` default to `false`. - systemd-specific eval assertions: `serviceConfig.Type` (simple/notify) and `serviceConfig.ExecReload` are asserted on the resolved host units. This directly guards the `mainExecReload` fix, which threw before it. - Runtime reload compliance test: a nested reloadable sub-service is started and reloaded, asserting the service observed the reload (recorded a SIGHUP marker). `callReload` receives the service's name path (the list of names from the top-level service down to the target sub-service); each integration joins it per its own unit-naming convention (NixOS dash-joins to the systemd unit name, e.g. `reload-inner.service`). Keeping it a path list rather than a read-only submodule option keeps the suite manager-agnostic. - `doc/build-helpers/testers.chapter.md`: document `callReload`. Follow-up to #535695. Signed-off-by: cinereal <cinereal@riseup.net> Assisted-by: Claude:claude-opus-4-8
Nixpkgs is a collection of over 140,000 software packages that can be installed with the Nix package manager. It also implements NixOS, a purely-functional Linux distribution.
Manuals
- NixOS Manual - how to install, configure, and maintain a purely-functional Linux distribution
- Nixpkgs Manual - contributing to Nixpkgs and using programming-language-specific Nix expressions
- Nix Package Manager Manual - how to write Nix expressions (programs), and how to use Nix command line tools
Community
- Discourse Forum
- Matrix Chat
- Official wiki
- Community-maintained list of ways to get in touch (Discord, Telegram, IRC, etc.)
Other Project Repositories
The sources of all official Nix-related projects are in the NixOS organization on GitHub. Here are some of the main ones:
- Nix - the purely functional package manager
- NixOps - the tool to remotely deploy NixOS machines
- nixos-hardware - NixOS profiles to optimize settings for different hardware
- Nix RFCs - the formal process for making substantial changes to the community
- NixOS homepage - the NixOS.org website
- hydra - our continuous integration system
- NixOS Branding - NixOS branding
Continuous Integration and Distribution
Nixpkgs and NixOS are built and tested by our continuous integration system, Hydra.
- Continuous package builds for unstable/master
- Continuous package builds for the NixOS 26.05 release
- Tests for unstable/master
- Tests for the NixOS 26.05 release
Artifacts successfully built with Hydra are published to cache at https://cache.nixos.org/. When successful build and test criteria are met, the Nixpkgs expressions are distributed via Nix channels.
Contributing
Nixpkgs is among the most active projects on GitHub. While thousands of open issues and pull requests might seem like a lot at first, it helps to consider it in the context of the scope of the project. Nixpkgs describes how to build tens of thousands of pieces of software and implements a Linux distribution. The GitHub Insights page gives a sense of the project activity.
Community contributions are always welcome through GitHub Issues and Pull Requests.
For more information about contributing to the project, please visit the contributing page.
Donations
The infrastructure for NixOS and related projects is maintained by a nonprofit organization, the NixOS Foundation. To ensure the continuity and expansion of the NixOS infrastructure, we are looking for donations to our organization.
You can donate to the NixOS Foundation through SEPA bank transfers or by using Open Collective:
License
Nixpkgs is licensed under the MIT License.
Note
MIT license does not apply to the packages built by Nixpkgs, merely to the files in this repository (the Nix expressions, build scripts, NixOS modules, etc.). It also might not apply to patches included in Nixpkgs, which may be derivative works of the packages to which they apply. The aforementioned artifacts are all covered by the licenses of the respective packages.