Files
quantenzitrone 18dc8a95fb various: switch buildPythonApplication packages to use finalAttrs
this shouldn't create any rebuilds

the following script was used to generate this:
```fish
#!/usr/bin/env fish

# nix shell .#nixfmt nixpkgs#{nixf-diagnose,ripgrep,sd}

set base (git rev-parse HEAD)

set scope pkgs/by-name
set builder buildPythonApplication

set files (rg --files-with-matches -F "$builder rec {" $scope | sort -u)

for file in $files
    echo $file
    sd -F "$builder rec {" "$builder (finalAttrs: {" $file
    # version
    sd -F 'version}' 'finalAttrs.version}' $file
    sd -F '${version' '${finalAttrs.version' $file
    sd -F '= version' '= finalAttrs.version' $file
    sd -F 'inherit version;' 'inherit (finalAttrs) version;' $file
    sd -F ' + version;' ' + finalAttrs.version;' $file
    sd 'replaceStrings (.*) version' 'replaceStrings $1 finalAttrs.version' $file
    sd -F 'splitVersion version' 'splitVersion finalAttrs.version' $file
    sd -F 'versionAtLeast version' 'versionAtLeast finalAttrs.version' $file
    sd 'versions\.([a-z]+) version' 'versions.$1 finalAttrs.version' $file
    # src
    sd -F 'src}' 'finalAttrs.src}' $file
    sd -F '${src' '${finalAttrs.src' $file
    sd -F '= src' '= finalAttrs.src' $file
    sd -F 'inherit src;' 'inherit (finalAttrs) src;' $file
    sd -F 'inherit (src' 'inherit (finalAttrs.src' $file
    # meta
    sd -F '${meta' '${finalAttrs.meta' $file
    sd -F '= meta' '= finalAttrs.meta' $file
    sd -F 'inherit (meta' 'inherit (finalAttrs.meta' $file
    # pname (restored afterwards)
    sd -F 'pname}' 'finalAttrs.pname}' $file
    sd -F '${pname' '${finalAttrs.pname' $file
    sd -F '= pname' '= finalAttrs.pname' $file
    # combinations
    sd -F 'inherit version src;' 'inherit (finalAttrs) version src;' $file
    sd -F 'inherit src version;' 'inherit (finalAttrs) src version;' $file
    sd -F 'inherit version pname;' 'inherit (finalAttrs) version pname;' $file
    sd -F 'inherit pname version;' 'inherit (finalAttrs) pname version;' $file
    sd -F 'inherit pname src version;' 'inherit (finalAttrs) pname src version;' $file
    sd -F 'inherit pname version src;' 'inherit (finalAttrs) pname version src;' $file
    sd -F 'inherit src pname version;' 'inherit (finalAttrs) src pname version;' $file
    sd -F 'inherit src version pname;' 'inherit (finalAttrs) src version pname;' $file
    sd -F 'inherit version pname src;' 'inherit (finalAttrs) version pname src;' $file
    sd -F 'inherit version src pname;' 'inherit (finalAttrs) version src pname;' $file
    # other
    sd -F 'makeLibraryPath buildInputs' 'makeLibraryPath finalAttrs.buildInputs' $file
    sd -F 'nativeBuildInputs}' 'finalAttrs.nativeBuildInputs}' $file
    sd -F 'buildInputs}' 'finalAttrs.buildInputs}' $file
    sd -F 'propagatedBuildInputs}' 'finalAttrs.propagatedBuildInputs}' $file
    sd -F 'desktopItem}' 'finalAttrs.desktopItem}' $file
    sd -F 'runtimeLibs}' 'finalAttrs.runtimeLibs}' $file
    sd -F 'makePythonPath dependencies' 'makePythonPath finalAttrs.dependencies' $file
    sd -F 'makePythonPath propagatedBuildInputs' 'makePythonPath finalAttrs.propagatedBuildInputs' $file
    sd -F 'libPath}' 'finalAttrs.libPath}' $file
    sd -F 'runtimeDependencies}' 'finalAttrs.runtimeDependencies}' $file
    sd -F 'runtimeDeps}' 'finalAttrs.runtimeDeps}' $file
    sd -F 'nativeRuntimeInputs}' 'finalAttrs.nativeRuntimeInputs}' $file
    sd -F '(!doCheck)' '(!finalAttrs.doCheck)' $file
    sd -F 'optional doCheck' 'optional finalAttrs.doCheck' $file
    sd -F 'optionals doCheck' 'optionals finalAttrs.doCheck' $file
    sd -F '++ runtimeDependencies' '++ finalAttrs.runtimeDependencies' $file
    # close finalAttrs lambda
    echo ')' >>$file
    # catch some errors early
    if ! nixfmt $file
        git restore $file
        continue
    end
    if ! nixf-diagnose -i sema-primop-overridden $file
        git restore $file
        continue
    end
end

set torestore (rg -F .finalAttrs --files-with-matches $scope)
if test (count $torestore) -gt 0
    git restore $torestore
end
set torestore (rg -F finalAttrs.pname --files-with-matches $scope)
if test (count $torestore) -gt 0
    git restore $torestore
end

# commit for faster eval times
git add pkgs
git commit --no-gpg-sign -m temp
set torestore

for file in $files
    # file hasn't changed
    if git diff --quiet $base $file
        continue
    end
    # try to eval the package to definitely catch all errors
    echo $file
    set pname (string split / $file -f 4)
    if ! nix eval .#$pname
        set torestore $torestore $file
    end
end

# restore files that don't eval
git reset --soft $base
git restore --staged .
if test (count $torestore) -gt 0
    git restore $torestore
end
```

after that some manual cleanup was done:
- restoring files that cause changes in the number of lines
- restoring files that cause rebuilds
- restoring files that cause merge conflicts with staging
2026-02-07 10:06:06 +01:00

251 lines
7.1 KiB
Nix
Raw Permalink Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
{
lib,
stdenv,
python3Packages,
fetchFromGitHub,
# tests
cabal-install,
cargo,
gitMinimal,
go,
perl,
versionCheckHook,
writableTmpDirAsHomeHook,
coursier,
dotnet-sdk,
nodejs,
# passthru
callPackage,
pre-commit,
}:
let
i686Linux = stdenv.buildPlatform.system == "i686-linux";
in
python3Packages.buildPythonApplication (finalAttrs: {
pname = "pre-commit";
version = "4.5.1";
pyproject = true;
src = fetchFromGitHub {
owner = "pre-commit";
repo = "pre-commit";
tag = "v${finalAttrs.version}";
hash = "sha256-3E/haU7TzTr+Qj3KadC7BYwuECZPa2Q+NvG5e4SSKSA=";
};
patches = [
./languages-use-the-hardcoded-path-to-python-binaries.patch
./hook-tmpl.patch
./pygrep-pythonpath.patch
];
build-system = with python3Packages; [
setuptools
];
dependencies = with python3Packages; [
cfgv
identify
nodeenv
pyyaml
toml
virtualenv
];
nativeCheckInputs = [
cabal-install
cargo
gitMinimal
go
perl
versionCheckHook
writableTmpDirAsHomeHook
]
++ (with python3Packages; [
pytest-env
pytest-forked
pytest-xdist
pytestCheckHook
re-assert
])
++ lib.optionals (!i686Linux) [
# coursier can be moved back to the main nativeCheckInputs list once were able to bootstrap a
# JRE on i686-linux: <https://github.com/NixOS/nixpkgs/issues/314873>. When coursier gets
# moved back to the main nativeCheckInputs list, dont forget to re-enable the
# coursier-related test that is currently disabled on i686-linux.
coursier
# i686-linux: dotnet-sdk not available
dotnet-sdk
# nodejs can be moved back to the main nativeCheckInputs list once this
# issue is fixed: <https://github.com/NixOS/nixpkgs/issues/387658>. When nodejs gets
# moved back to the main nativeCheckInputs list, dont forget to re-enable the
# Node.js-related tests that are currently disabled on i686-linux.
nodejs
];
postPatch = ''
substituteInPlace pre_commit/resources/hook-tmpl \
--subst-var-by pre-commit $out
substituteInPlace pre_commit/languages/python.py \
--subst-var-by virtualenv ${python3Packages.virtualenv}
substituteInPlace pre_commit/languages/node.py \
--subst-var-by nodeenv ${python3Packages.nodeenv}
patchShebangs pre_commit/resources/hook-tmpl
'';
pytestFlags = [
"--forked"
];
preCheck =
lib.optionalString (!(stdenv.hostPlatform.isLinux && stdenv.hostPlatform.isAarch64)) ''
# Disable outline atomics for rust tests on aarch64-linux.
export RUSTFLAGS="-Ctarget-feature=-outline-atomics"
''
+ ''
export GIT_AUTHOR_NAME=test GIT_COMMITTER_NAME=test \
GIT_AUTHOR_EMAIL=test@example.com GIT_COMMITTER_EMAIL=test@example.com \
VIRTUALENV_NO_DOWNLOAD=1 PRE_COMMIT_NO_CONCURRENCY=1
''
+ lib.optionalString (!i686Linux) ''
# Resolve `.NET location: Not found` errors for dotnet tests
export DOTNET_ROOT="${dotnet-sdk}/share/dotnet"
''
+ ''
git init -b master
python -m venv --system-site-packages venv
source "$PWD/venv/bin/activate"
'';
postCheck = ''
deactivate
'';
disabledTests = [
# ERROR: The install method you used for conda--probably either `pip install conda`
# or `easy_install conda`--is not compatible with using conda as an application.
"test_conda_"
"test_local_conda_"
# /build/pytest-of-nixbld/pytest-0/test_install_ruby_with_version0/rbenv-2.7.2/libexec/rbenv-init:
# /usr/bin/env: bad interpreter: No such file or directory
"test_ruby_"
# network
"test_additional_dependencies_roll_forward"
"test_additional_golang_dependencies_installed"
"test_additional_node_dependencies_installed"
"test_additional_rust_cli_dependencies_installed"
"test_additional_rust_lib_dependencies_installed"
"test_automatic_toolchain_switching"
"test_coursier_hook"
"test_coursier_hook_additional_dependencies"
"test_dart"
"test_dart_additional_deps"
"test_dart_additional_deps_versioned"
"test_during_commit_all"
"test_golang_default_version"
"test_golang_hook"
"test_golang_hook_still_works_when_gobin_is_set"
"test_golang_infer_go_version_default"
"test_golang_system"
"test_golang_versioned"
"test_language_version_with_rustup"
"test_installs_rust_missing_rustup"
"test_installs_without_links_outside_env"
"test_julia_hook"
"test_julia_repo_local"
"test_local_golang_additional_deps"
"test_lua"
"test_lua_additional_dependencies"
"test_node_additional_deps"
"test_node_hook_versions"
"test_perl_additional_dependencies"
"test_r_hook"
"test_r_inline"
"test_r_inline_hook"
"test_r_local_with_additional_dependencies_hook"
"test_r_with_additional_dependencies_hook"
"test_run_a_node_hook_default_version"
"test_run_lib_additional_dependencies"
"test_run_versioned_node_hook"
"test_rust_cli_additional_dependencies"
"test_swift_language"
"test_run_example_executable"
"test_run_dep"
"test_control_c_control_c_on_install"
"test_healthy_default_creator"
"test_healthy_venv_creator"
"test_invalidated_virtualenv"
"test_language_versioned_python_hook"
"test_local_python_repo"
"test_local_repo_with_other_artifacts"
"test_python_hook_weird_setup_cfg"
"test_really_long_file_paths"
"test_reinstall"
"test_repository_state_compatibility[v1]"
"test_repository_state_compatibility[v2]"
"test_simple_python_hook_default_version"
"test_simple_python_hook"
"test_unhealthy_old_virtualenv"
"test_unhealthy_python_goes_missing"
"test_unhealthy_system_version_changes"
"test_unhealthy_then_replaced"
"test_unhealthy_unexpected_pyvenv"
"test_unhealthy_with_version_change"
# i don't know why these fail
"test_install_existing_hooks_no_overwrite"
"test_installed_from_venv"
"test_uninstall_restores_legacy_hooks"
"test_dotnet_"
"test_health_check_"
# Expects `git commit` to fail when `pre-commit` is not in the `$PATH`,
# but we use an absolute path so it's not an issue.
"test_environment_not_sourced"
# Docker required
"test_docker_"
]
++ lib.optionals i686Linux [
# From coursier_test.py:
"test_error_if_no_deps_or_channel"
# From node_test.py:
"test_healthy_system_node"
"test_unhealthy_if_system_node_goes_missing"
"test_node_hook_system"
"test_node_with_user_config_set"
];
pythonImportsCheck = [
"pre_commit"
];
# add gitMinimal as fallback, if git is not installed
preFixup = ''
makeWrapperArgs+=(--suffix PATH : ${lib.makeBinPath [ gitMinimal ]})
'';
passthru.tests = callPackage ./tests.nix {
inherit gitMinimal pre-commit;
};
meta = {
description = "Framework for managing and maintaining multi-language pre-commit hooks";
homepage = "https://pre-commit.com/";
changelog = "https://github.com/pre-commit/pre-commit/blob/${finalAttrs.src.tag}/CHANGELOG.md";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [
borisbabic
savtrip
];
mainProgram = "pre-commit";
};
})