Adding or changing ExecReload now triggers a reload, but removing it
still triggered a restart. The running process is unaffected by the
removal and the new unit no longer has a reload command to invoke, so
treat it like the other ignored [Unit] keys and take no action.
Covers both "key removed from existing [Service]" and "[Service]
section removed that only contained ExecReload".
When exactly one section was newly introduced, the code looked up
new_unit.get("Unit") first regardless of which section was actually
new. If [Service] was the new section but the unit also had an
unchanged [Unit] section, the [Service] contents were never inspected
and a newly added ExecStart= would not trigger a restart.
Dispatch on section_cmp instead and add unit tests for both the
restart and reload cases.
The branch handling "a key was added to an existing section" compared
the section name against "Exec" (the .nspawn section header) instead of
"Service", so adding ExecReload= to a [Service] that previously lacked
it still triggered a restart instead of a reload.
Add a unit test covering this path.
Instead of triggering a restart when the reload script changes, signal
that the unit only needs to be reloaded instead. This is an important
optimisation for systemd-nspawn containers where the reload script
can house the container's config activation script and we want to
explicitly avoid restarting.
The old URL wasn't broken completely per se, as the user was redirected
to the correct page using JavaScript. But the initial request still
returned 404.
See #514132 w.r.t to floorp-bin / floorp-bin-unwrapped.
Signed-off-by: Christoph Heiss <christoph@c8h4.io>
The Fish test no longer functions, as Starship is not displayed inside the test
environment. Given that Starship on Fish works otherwise, it is safe to
temporarily disable the test until a suitable fix is identified.
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Fernando Rodrigues