unityhub: drop 2019 support to fix build, 3.12.1 -> 3.13.1 (#422785)

pkgs/by-name/un/unityhub/package.nix

@@ -11,11 +11,11 @@
 
 stdenv.mkDerivation rec {
   pname = "unityhub";
-  version = "3.12.1";
+  version = "3.13.1";
 
   src = fetchurl {
     url = "https://hub-dist.unity3d.com/artifactory/hub-debian-prod-local/pool/main/u/unity/unityhub_amd64/unityhub-amd64-${version}.deb";
-    sha256 = "sha256-Zpzl3H8cgVmPqpRAakL3m12OZ04Ddzpm+2krkuEkwrk=";
+    hash = "sha256-gBQrz6CNlUyhxeLmY6tNtxpaQJSEW00r7MGyIDtYdiY=";
   };
 
   nativeBuildInputs = [
@@ -96,17 +96,22 @@ stdenv.mkDerivation rec {
         xorg.libXcursor
         glib
         gdk-pixbuf
-        libxml2
+        (libxml2.overrideAttrs (oldAttrs: rec {
+          version = "2.13.8";
+          src = fetchurl {
+            url = "mirror://gnome/sources/libxml2/${lib.versions.majorMinor version}/libxml2-${version}.tar.xz";
+            hash = "sha256-J3KUyzMRmrcbK8gfL0Rem8lDW4k60VuyzSsOhZoO6Eo=";
+          };
+          meta = oldAttrs.meta // {
+            knownVulnerabilities = oldAttrs.meta.knownVulnerabilities or [ ] ++ [
+              "CVE-2025-6021"
+            ];
+          };
+        }))
         zlib
         clang
         git # for git-based packages in unity package manager
 
-        # Unity Editor 2019 specific dependencies
-        xorg.libXi
-        xorg.libXrender
-        gnome2.GConf
-        libcap
-
         # Unity Editor 6000 specific dependencies
         harfbuzz
         vulkan-loader
@@ -123,8 +128,6 @@ stdenv.mkDerivation rec {
       ++ extraLibs pkgs;
   };
 
-  unpackCmd = "dpkg -x $curSrc src";
-
   dontConfigure = true;
   dontBuild = true;
 
@@ -135,35 +138,31 @@ stdenv.mkDerivation rec {
     mv opt/ usr/share/ $out
 
     # `/opt/unityhub/unityhub` is a shell wrapper that runs `/opt/unityhub/unityhub-bin`
-    # Which we don't need and overwrite with our own custom wrapper
+    # which we don't need and overwrite with our own wrapper that uses the fhs env.
     makeWrapper ${fhsEnv}/bin/${pname}-fhs-env $out/opt/unityhub/unityhub \
       --add-flags $out/opt/unityhub/unityhub-bin \
       --argv0 unityhub
 
-    # Link binary
     mkdir -p $out/bin
     ln -s $out/opt/unityhub/unityhub $out/bin/unityhub
 
     # Replace absolute path in desktop file to correctly point to nix store
     substituteInPlace $out/share/applications/unityhub.desktop \
-      --replace /opt/unityhub/unityhub $out/opt/unityhub/unityhub
+      --replace-fail /opt/unityhub/unityhub $out/opt/unityhub/unityhub
 
     runHook postInstall
   '';
 
   passthru.updateScript = ./update.sh;
 
-  meta = with lib; {
+  meta = {
     description = "Official Unity3D app to download and manage Unity Projects and installations";
     homepage = "https://unity.com/";
     downloadPage = "https://unity.com/unity-hub";
-    changelog = "https://unity.com/unity-hub/release-notes";
-    license = licenses.unfree;
-    maintainers = with maintainers; [
-      tesq0
-      huantian
-    ];
+    changelog = "https://unity.com/unity-hub/release-notes#${version}";
+    license = lib.licenses.unfree;
+    maintainers = with lib.maintainers; [ huantian ];
     platforms = [ "x86_64-linux" ];
-    sourceProvenance = with sourceTypes; [ binaryNativeCode ];
+    sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ];
   };
 }

pkgs/by-name/un/unityhub/update.sh

@@ -3,7 +3,7 @@
 # set -euo pipefail
 
 new_version="$(curl https://hub-dist.unity3d.com/artifactory/hub-debian-prod-local/dists/stable/main/binary-amd64/Packages --silent | sed -nE "s/^Version: ([0-9]+\.[0-9]+\.[0-9]+)$/\1/p" | sort -V | tail -n 1)"
-old_version="$(sed -nE 's/^\s*version = "([0-9]+\.[0-9]+\.[0-9]+)";$/\1/p' ./default.nix)"
+old_version="$(sed -nE 's/^\s*version = "([0-9]+\.[0-9]+\.[0-9]+)";$/\1/p' ./package.nix)"
 
 if [[ "$new_version" == "$old_version" ]]; then
     echo "Up to date"

pkgs/top-level/all-packages.nix

@@ -16064,8 +16064,6 @@ with pkgs;
 
   terraform-landscape = callPackage ../applications/networking/cluster/terraform-landscape { };
 
-  unityhub = callPackage ../development/tools/unityhub { };
-
   vaultenv = haskell.lib.justStaticExecutables haskellPackages.vaultenv;
 
   vaultwarden-sqlite = vaultwarden;