python313Packages.websockets: disable failing test, cleanup

This commit is contained in:
FliegendeWurst
2025-01-05 21:04:11 +01:00
parent 844f2a5fff
commit f5097a67ea
@@ -4,6 +4,7 @@
buildPythonPackage,
fetchFromGitHub,
unittestCheckHook,
pythonAtLeast,
pythonOlder,
setuptools,
}:
@@ -24,38 +25,36 @@ buildPythonPackage rec {
build-system = [ setuptools ];
patchPhase =
''
# Disable all tests that need to terminate within a predetermined amount of
# time. This is nondeterministic.
sed -i 's/with self.assertCompletesWithin.*:/if True:/' \
tests/legacy/test_protocol.py
disabledTests =
[
# Disables tests relying on tight timeouts to avoid failures like:
# File "/build/source/tests/legacy/test_protocol.py", line 1270, in test_keepalive_ping_with_no_ping_timeout
# ping_1_again, ping_2 = tuple(self.protocol.pings)
# ValueError: too many values to unpack (expected 2)
for t in \
test_keepalive_ping_stops_when_connection_closing \
test_keepalive_ping_does_not_crash_when_connection_lost \
test_keepalive_ping \
test_keepalive_ping_not_acknowledged_closes_connection \
test_keepalive_ping_with_no_ping_timeout \
; do
sed -i "s/def $t(/def skip_$t(/" tests/legacy/test_protocol.py
done
''
+ lib.optionalString (pythonOlder "3.11") ''
"test_keepalive_ping_stops_when_connection_closing"
"test_keepalive_ping_does_not_crash_when_connection_lost"
"test_keepalive_ping"
"test_keepalive_ping_not_acknowledged_closes_connection"
"test_keepalive_ping_with_no_ping_timeout"
]
++ lib.optionals (pythonAtLeast "3.13") [
# https://github.com/python-websockets/websockets/issues/1569
"test_writing_in_send_context_fails"
]
++ lib.optionals (pythonOlder "3.11") [
# Our Python 3.10 and older raise SSLError instead of SSLCertVerificationError
sed -i "s/def test_reject_invalid_server_certificate(/def skip_test_reject_invalid_server_certificate(/" tests/sync/test_client.py
sed -i "s/def test_reject_invalid_server_certificate(/def skip_test_reject_invalid_server_certificate(/" tests/asyncio/test_client.py
'';
"test_reject_invalid_server_certificate"
];
nativeCheckInputs = [ unittestCheckHook ];
preCheck = ''
# https://github.com/python-websockets/websockets/issues/1509
export WEBSOCKETS_TESTS_TIMEOUT_FACTOR=100
# Disable all tests that need to terminate within a predetermined amount of
# time. This is nondeterministic.
sed -i 's/with self.assertCompletesWithin.*:/if True:/' \
tests/legacy/test_protocol.py
'';
# Tests fail on Darwin with `OSError: AF_UNIX path too long`