faiss: cleanup (#461197)

pkgs/by-name/fa/faiss/package.nix

@@ -24,9 +24,6 @@
 }@inputs:
 
 let
-  pname = "faiss";
-  version = "1.13.0";
-
   inherit (cudaPackages) flags backendStdenv;
 
   stdenv = if cudaSupport then backendStdenv else inputs.stdenv;
@@ -41,15 +38,16 @@ let
     (cudaPackages.cuda_profiler_api or cudaPackages.cuda_nvprof)
   ];
 in
-stdenv.mkDerivation {
-  inherit pname version;
+stdenv.mkDerivation (finalAttrs: {
+  pname = "faiss";
+  version = "1.13.0";
 
   outputs = [ "out" ] ++ lib.optionals pythonSupport [ "dist" ];
 
   src = fetchFromGitHub {
     owner = "facebookresearch";
     repo = "faiss";
-    tag = "v${version}";
+    tag = "v${finalAttrs.version}";
     hash = "sha256-8o66YbAH2pqPjW7yG2pfuEdEyEzoopE2DJNV70XymUY=";
   };
 
@@ -105,9 +103,9 @@ stdenv.mkDerivation {
     description = "Library for efficient similarity search and clustering of dense vectors by Facebook Research";
     mainProgram = "demo_ivfpq_indexing";
     homepage = "https://github.com/facebookresearch/faiss";
-    changelog = "https://github.com/facebookresearch/faiss/blob/v${version}/CHANGELOG.md";
+    changelog = "https://github.com/facebookresearch/faiss/blob/v${finalAttrs.version}/CHANGELOG.md";
     license = lib.licenses.mit;
     platforms = lib.platforms.unix;
     maintainers = with lib.maintainers; [ SomeoneSerge ];
   };
-}
+})