milkytracker: 1.04.00 -> 1.05.01 (#362208)

pkgs/applications/audio/milkytracker/default.nix

@@ -1,86 +0,0 @@
-{ lib
-, stdenv
-, fetchFromGitHub
-, fetchpatch
-, gitUpdater
-, alsa-lib
-, cmake
-, Cocoa
-, CoreAudio
-, Foundation
-, libjack2
-, lhasa
-, makeWrapper
-, perl
-, pkg-config
-, rtmidi
-, SDL2
-, zlib
-, zziplib
-}:
-
-stdenv.mkDerivation (finalAttrs: {
-  pname = "milkytracker";
-  version = "1.04.00";
-
-  src = fetchFromGitHub {
-    owner = "milkytracker";
-    repo = "MilkyTracker";
-    rev = "v${finalAttrs.version}";
-    hash = "sha256-ta4eV/FGBfgTppJwDam0OKQ7udtlinbWly/FPCE+Qss=";
-  };
-
-  patches = [
-    # Fix crash after querying midi ports
-    # Remove when version > 1.04.00
-    (fetchpatch {
-      url = "https://github.com/milkytracker/MilkyTracker/commit/7e9171488fc47ad2de646a4536794fda21e7303d.patch";
-      hash = "sha256-CmnIwmGGnsnlRrvVAXe2zaQf1CFMB5BJPKmiwGOHgGY=";
-    })
-  ];
-
-  strictDeps = true;
-
-  nativeBuildInputs = [
-    cmake
-    makeWrapper
-    pkg-config
-  ];
-
-  buildInputs = [
-    lhasa
-    libjack2
-    perl
-    rtmidi
-    SDL2
-    zlib
-    zziplib
-  ] ++ lib.optionals stdenv.hostPlatform.isLinux [
-    alsa-lib
-  ] ++ lib.optionals stdenv.hostPlatform.isDarwin [
-    Cocoa
-    CoreAudio
-    Foundation
-  ];
-
-  postInstall = lib.optionalString stdenv.hostPlatform.isLinux ''
-    install -Dm644 $src/resources/milkytracker.desktop $out/share/applications/milkytracker.desktop
-    install -Dm644 $src/resources/pictures/carton.png $out/share/pixmaps/milkytracker.png
-    install -Dm644 $src/resources/milkytracker.appdata $out/share/appdata/milkytracker.appdata.xml
-  '';
-
-  passthru.updateScript = gitUpdater {
-    rev-prefix = "v";
-  };
-
-  meta = with lib; {
-    description = "Music tracker application, similar to Fasttracker II";
-    homepage = "https://milkytracker.org/";
-    license = licenses.gpl3Plus;
-    platforms = platforms.unix;
-    # ibtool -> real Xcode -> I can't get that, and Ofborg can't test that
-    broken = stdenv.hostPlatform.isDarwin;
-    maintainers = with maintainers; [ OPNA2608 ];
-    mainProgram = "milkytracker";
-  };
-})

pkgs/by-name/mi/milkytracker/package.nix

@@ -0,0 +1,70 @@
+{
+  lib,
+  stdenv,
+  fetchFromGitHub,
+  gitUpdater,
+  alsa-lib,
+  cmake,
+  libjack2,
+  lhasa,
+  makeWrapper,
+  pkg-config,
+  rtmidi,
+  SDL2,
+  zlib,
+  zziplib,
+}:
+
+stdenv.mkDerivation (finalAttrs: {
+  pname = "milkytracker";
+  version = "1.05.01";
+
+  src = fetchFromGitHub {
+    owner = "milkytracker";
+    repo = "MilkyTracker";
+    rev = "v${finalAttrs.version}";
+    hash = "sha256-31Jy93bQj9wZ9vWJe5DVnBqFXfPSH1qmk8kcT/t+FY0=";
+  };
+
+  strictDeps = true;
+
+  nativeBuildInputs = [
+    cmake
+    makeWrapper
+    pkg-config
+  ];
+
+  buildInputs =
+    [
+      lhasa
+      libjack2
+      rtmidi
+      SDL2
+      zlib
+      zziplib
+    ]
+    ++ lib.optionals stdenv.hostPlatform.isLinux [
+      alsa-lib
+    ];
+
+  postInstall = lib.optionalString stdenv.hostPlatform.isLinux ''
+    install -Dm644 $src/resources/milkytracker.desktop $out/share/applications/milkytracker.desktop
+    install -Dm644 $src/resources/pictures/carton.png $out/share/pixmaps/milkytracker.png
+    install -Dm644 $src/resources/org.milkytracker.MilkyTracker.metainfo.xml $out/share/appdata/org.milkytracker.MilkyTracker.metainfo.xml
+  '';
+
+  passthru.updateScript = gitUpdater {
+    rev-prefix = "v";
+  };
+
+  meta = {
+    description = "Music tracker application, similar to Fasttracker II";
+    homepage = "https://milkytracker.org/";
+    license = lib.licenses.gpl3Plus;
+    platforms = lib.platforms.unix;
+    # ibtool -> real Xcode -> I can't get that, and Ofborg can't test that
+    broken = stdenv.hostPlatform.isDarwin;
+    maintainers = with lib.maintainers; [ OPNA2608 ];
+    mainProgram = "milkytracker";
+  };
+})

pkgs/top-level/all-packages.nix

@@ -13255,10 +13255,6 @@ with pkgs;
       stdenv;
   };
 
-  milkytracker = callPackage ../applications/audio/milkytracker {
-    inherit (darwin.apple_sdk.frameworks) Cocoa CoreAudio Foundation;
-  };
-
   ptcollab = callPackage ../by-name/pt/ptcollab/package.nix {
     stdenv = if stdenv.hostPlatform.isDarwin then darwin.apple_sdk_11_0.stdenv else stdenv;
   };