Merge pull request #317324 from ConnorBaker/fix/python3Packages.fipy

python3Packages.fipy: disable on Python 3.12+ and skip checkPhase
This commit is contained in:
Jonas Heinrich
2024-06-15 16:55:20 +02:00
committed by GitHub
@@ -14,6 +14,7 @@
stdenv,
openssh,
fetchFromGitHub,
pythonAtLeast,
pythonOlder,
}:
@@ -22,7 +23,10 @@ buildPythonPackage rec {
version = "3.4.4";
format = "setuptools";
disabled = pythonOlder "3.7";
# Python 3.12 is not yet supported.
# https://github.com/usnistgov/fipy/issues/997
# https://github.com/usnistgov/fipy/pull/1023
disabled = pythonOlder "3.7" || pythonAtLeast "3.12";
src = fetchFromGitHub {
owner = "usnistgov";
@@ -45,12 +49,18 @@ buildPythonPackage rec {
nativeCheckInputs = lib.optionals (!stdenv.isDarwin) [ gmsh ];
# NOTE: Two of the doctests in fipy.matrices.scipyMatrix._ScipyMatrix.CSR fail, and there is no
# clean way to disable them.
doCheck = false;
checkPhase = ''
export OMPI_MCA_plm_rsh_agent=${openssh}/bin/ssh
${python.interpreter} setup.py test --modules
'';
pythonImportsCheck = [ "fipy" ];
# NOTE: Importing fipy within the sandbox will fail because plm_rsh_agent isn't set and the process isn't able
# to start a daemon on the builder.
# pythonImportsCheck = [ "fipy" ];
meta = with lib; {
homepage = "https://www.ctcms.nist.gov/fipy/";