libsnark: refactor, unstable-2018-01-15 -> 20140603-unstable-2024-02-23, fix build (#353177)

pkgs/by-name/li/libsnark/package.nix

@@ -0,0 +1,50 @@
+{
+  lib,
+  stdenv,
+  fetchFromGitHub,
+  cmake,
+  pkg-config,
+  openssl,
+  boost,
+  gmp,
+  withProcps ? false,
+  procps,
+}:
+
+stdenv.mkDerivation {
+  pname = "libsnark";
+  version = "20140603-unstable-2024-02-23";
+
+  nativeBuildInputs = [
+    cmake
+    pkg-config
+  ];
+  buildInputs = [
+    openssl
+    boost
+    gmp
+  ] ++ lib.optional withProcps procps;
+
+  cmakeFlags =
+    lib.optionals (!withProcps) [ "-DWITH_PROCPS=OFF" ]
+    ++ lib.optionals (stdenv.hostPlatform.isDarwin || !stdenv.hostPlatform.isx86) [
+      "-DWITH_SUPERCOP=OFF"
+    ]
+    ++ lib.optionals (!stdenv.hostPlatform.isx86) [ "-DCURVE=ALT_BN128" ];
+
+  src = fetchFromGitHub {
+    owner = "scipr-lab";
+    repo = "libsnark";
+    rev = "6c705e3135f585c222813654caedc86520fda1f6";
+    hash = "sha256-5Gk24fwVaXBWEFmhTsN9Qm8x/Qpr1KjavI3staJidxQ=";
+    fetchSubmodules = true;
+  };
+
+  meta = {
+    broken = withProcps; # Despite procps having a valid pkg-config file, CMake doesn't seem to be able to find it.
+    description = "C++ library for zkSNARKs";
+    homepage = "https://github.com/scipr-lab/libsnark";
+    license = lib.licenses.mit;
+    platforms = lib.platforms.all;
+  };
+}

pkgs/development/libraries/libsnark/default.nix

@@ -1,28 +0,0 @@
-{ lib, stdenv, fetchFromGitHub, cmake, pkg-config, openssl, boost, gmp, procps }:
-
-stdenv.mkDerivation rec {
-  pname = "libsnark";
-  version = "unstable-2018-01-15";
-
-  nativeBuildInputs = [ cmake pkg-config ];
-  buildInputs = [ openssl boost gmp ] ++ lib.optional stdenv.hostPlatform.isLinux procps;
-
-  cmakeFlags = lib.optionals stdenv.hostPlatform.isDarwin [ "-DWITH_PROCPS=OFF" ]
-    ++ lib.optionals (stdenv.hostPlatform.isDarwin || !stdenv.hostPlatform.isx86) [ "-DWITH_SUPERCOP=OFF" ]
-    ++ lib.optionals (!stdenv.hostPlatform.isx86) [ "-DCURVE=ALT_BN128" ];
-
-  src = fetchFromGitHub {
-    rev = "9e6b19ff15bc19fba5da1707ba18e7f160e5ed07";
-    owner           = "scipr-lab";
-    repo            = "libsnark";
-    sha256          = "13f02qp2fmfhvxlp4xi69m0l8r5nq913l2f0zwdk7hl46lprfdca";
-    fetchSubmodules = true;
-  };
-
-  meta = with lib; {
-    description = "C++ library for zkSNARKs";
-    homepage = "https://github.com/scipr-lab/libsnark";
-    license = licenses.mit;
-    platforms = lib.platforms.linux ++ lib.platforms.darwin;
-  };
-}

pkgs/top-level/all-packages.nix

@@ -21359,8 +21359,6 @@ with pkgs;
     inherit (darwin.apple_sdk.frameworks) Carbon AudioToolbox;
   };
 
-  libsnark = callPackage ../development/libraries/libsnark { };
-
   libsodium = callPackage ../development/libraries/libsodium { };
 
   libsoup = callPackage ../development/libraries/libsoup { };