rocmPackages.rocm-path: drop

rocm-path shouldn't have been added at top-level.
We have a separate non-recursed section containing symlinkJoins for
this, and best practice in nixpkgs is to avoid ROCM_PATH when possible
and create a minimal one in each package that needs one.
This commit is contained in:
Luna Nova
2025-10-02 08:12:36 -07:00
parent 6fb5f7ac2e
commit c1cfcf3822
2 changed files with 7 additions and 28 deletions
+7 -1
View File
@@ -30,7 +30,6 @@ let
buildTests = false;
buildBenchmarks = false;
rocmPath = self.callPackage ./rocm-path { };
rocmUpdateScript = self.callPackage ./update.nix { };
## ROCm ##
@@ -417,6 +416,13 @@ let
};
}
// lib.optionalAttrs config.allowAliases {
rocmPath = throw ''
'rocm-path' has been removed. If a ROCM_PATH value is required in nixpkgs please
construct one with the minimal set of required deps.
For convenience use outside of nixpkgs consider one of the entries in
'rocmPackages.meta'.
''; # Added 2025-09-30
rocm-merged-llvm = throw ''
'rocm-merged-llvm' has been removed.
For 'libllvm' or 'libclang' use 'rocmPackages.llvm.libllvm/clang'.
@@ -1,27 +0,0 @@
{
symlinkJoin,
linkFarm,
clr,
hipblas,
hipblas-common,
rocblas,
rocsolver,
rocsparse,
rocm-device-libs,
rocm-smi,
llvm,
}:
symlinkJoin {
name = "rocm-path-${clr.version}";
paths = [
clr
hipblas-common
hipblas
rocblas
rocsolver
rocsparse
rocm-device-libs
rocm-smi
(linkFarm "rocm-llvm-subdir" { llvm = llvm.clang; })
];
}