gador/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sm64coopdx: Switch back to using tag instead of rev when fetching src

Browse Source 
Before 1f2c3637d5, the sm64coopdx package
fetched its source by doing this:

>   src = fetchFromGitHub {
>     owner = "coop-deluxe";
>     repo = "sm64coopdx";
>     tag = "v${finalAttrs.version}";
>     hash = "<whatever>";
>   };

1f2c3637d5 made it so that the sm64coopdx
package fetched its source by doing this:

>   src = fetchFromGitHub {
>     owner = "coop-deluxe";
>     repo = "sm64coopdx";
>     # Replace with `tag = "v${finalAttrs.version}";` in the next version. The upstream repository tagged the wrong commit.
>     rev = "<whatever>";
>     hash = "<whatever>;
>   };

Switching from using ‘tag = "v${finalAttrs.version}";’ to
‘rev = "<whatever>";’ was only necessary because of an upstream
sm64coopdx bug [1]. Now that that bug has been fixed, we can switch back
to using ‘tag = "v${finalAttrs.version}";’.

[1]: <https://github.com/coop-deluxe/sm64coopdx/issues/1078>
This commit is contained in:
Jason Yundt
2026-05-09 18:16:29 -04:00
parent 7482cd1454
commit b6b9a78f41
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkgs/by-name/sm/sm64coopdx/package.nix
+1 -2
View File
@@ -45,8 +45,7 @@ stdenv.mkDerivation (finalAttrs: {
src = fetchFromGitHub {
owner = "coop-deluxe";
repo = "sm64coopdx";
# Replace with `tag = "v${finalAttrs.version}";` in the next version. The upstream repository tagged the wrong commit.
rev = "6092488d1c4fc741b16a0789ef9c08ec0279333f";
tag = "v${finalAttrs.version}";
hash = "sha256-BIdKKIp6q9Vp2DByXzT9CJzOszFhjriiWBEqFwUT28M=";
};