networkmanager: enable firewalld support (#463498)

nixos/modules/services/networking/networkmanager.nix

@@ -698,6 +698,8 @@ in
 
     services.dbus.packages = packages ++ pluginDbusDeps ++ optional (cfg.dns == "dnsmasq") pkgs.dnsmasq;
 
+    services.firewalld.packages = packages;
+
     services.udev.packages = packages;
 
     systemd.services.NetworkManager.path = pluginRuntimeDeps;

pkgs/by-name/ne/networkmanager/package.nix

@@ -123,8 +123,6 @@ stdenv.mkDerivation (finalAttrs: {
     # almost cross-compiles, however fails with
     # ** (process:9234): WARNING **: Failed to load shared library '/nix/store/...-networkmanager-aarch64-unknown-linux-gnu-1.38.2/lib/libnm.so.0' referenced by the typelib: /nix/store/...-networkmanager-aarch64-unknown-linux-gnu-1.38.2/lib/libnm.so.0: cannot open shared object file: No such file or directory
     "-Ddocs=${lib.boolToString (stdenv.buildPlatform == stdenv.hostPlatform)}"
-    # We don't use firewalld in NixOS
-    "-Dfirewalld_zone=false"
     "-Dtests=no"
     "-Dcrypto=gnutls"
     "-Dmobile_broadband_provider_info_database=${mobile-broadband-provider-info}/share/mobile-broadband-provider-info/serviceproviders.xml"