ldmud: apply some small modernizations

Catches up with some best practices.

pkgs/by-name/ld/ldmud/package.nix

@@ -26,15 +26,15 @@
   python310,
 }:
 
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "ldmud";
   version = "3.6.7";
 
   src = fetchFromGitHub {
     owner = "ldmud";
     repo = "ldmud";
-    rev = version;
-    sha256 = "sha256-PkrjP7tSZMaj61Hsn++7+CumhqFPLbf0+eAI6afP9HA=";
+    tag = finalAttrs.version;
+    hash = "sha256-PkrjP7tSZMaj61Hsn++7+CumhqFPLbf0+eAI6afP9HA=";
   };
 
   patches = [
@@ -42,13 +42,14 @@ stdenv.mkDerivation rec {
     ./mysql-compat.patch
   ];
 
-  sourceRoot = "${src.name}/src";
+  sourceRoot = "${finalAttrs.src.name}/src";
 
   nativeBuildInputs = [
     autoreconfHook
     pkg-config
     bison
   ];
+
   buildInputs =
     [
       libgcrypt
@@ -105,7 +106,7 @@ stdenv.mkDerivation rec {
   meta = {
     description = "Gamedriver for LPMuds including a LPC compiler, interpreter and runtime";
     homepage = "https://ldmud.eu";
-    changelog = "https://github.com/ldmud/ldmud/blob/${version}/HISTORY";
+    changelog = "https://github.com/ldmud/ldmud/blob/${finalAttrs.version}/HISTORY";
     longDescription = ''
       LDMud started as a project to clean up and modernize Amylaar's LPMud
       gamedriver. Primary goals are full documentation, a commented source body
@@ -120,4 +121,4 @@ stdenv.mkDerivation rec {
     platforms = with lib.platforms; linux ++ darwin;
     maintainers = with lib.maintainers; [ cpu ];
   };
-}
+})