various: remove unused arguments, use finalAttrs (#518844)

pkgs/by-name/es/eslint/package.nix

@@ -4,14 +4,14 @@
   fetchFromGitHub,
   nix-update-script,
 }:
-buildNpmPackage rec {
+buildNpmPackage (finalAttrs: {
   pname = "eslint";
   version = "10.3.0";
 
   src = fetchFromGitHub {
     owner = "eslint";
     repo = "eslint";
-    tag = "v${version}";
+    tag = "v${finalAttrs.version}";
     hash = "sha256-b0Gv7soMPTsbMOZLqMe5vMCPwInk9AFusepf2jJH/Ng=";
   };
 
@@ -35,7 +35,7 @@ buildNpmPackage rec {
   };
 
   meta = {
-    changelog = "https://github.com/eslint/eslint/blob/${src.tag}/CHANGELOG.md";
+    changelog = "https://github.com/eslint/eslint/blob/${finalAttrs.src.rev}/CHANGELOG.md";
     description = "Find and fix problems in your JavaScript code";
     homepage = "https://eslint.org";
     license = lib.licenses.mit;
@@ -44,4 +44,4 @@ buildNpmPackage rec {
       onny
     ];
   };
-}
+})

pkgs/by-name/ni/nixpkgs-vet/package.nix

@@ -1,7 +1,6 @@
 {
   fetchFromGitHub,
   lib,
-  nix,
   nix-update-script,
   rustPlatform,
 }:

pkgs/os-specific/linux/procps-ng/default.nix

@@ -1,7 +1,6 @@
 {
   lib,
   stdenv,
-  fetchpatch2,
   fetchurl,
   ncurses,
   pkg-config,

pkgs/tools/text/gnupatch/default.nix

@@ -4,7 +4,6 @@
   fetchurl,
   ed,
   autoreconfHook,
-  testers,
 }:
 
 stdenv.mkDerivation (finalAttrs: {
@@ -27,7 +26,7 @@ stdenv.mkDerivation (finalAttrs: {
     "ac_cv_func_strnlen_working=yes"
   ];
 
-  doCheck = stdenv.hostPlatform.libc != "musl"; # not cross;
+  doCheck = stdenv.hostPlatform.libc != "musl";
   nativeCheckInputs = [ ed ];
 
   meta = {