stdenv.mkDerivation: warn on nested lists (#521144)

doc/release-notes/rl-2605.section.md

@@ -410,6 +410,8 @@ gnuradioMinimal.override {
 
 - `fetchFromSavannah` is now deprecated and is expected to be fully removed in a future release. From now on, use `fetchgit` or a Savannah releases mirror when applicable.
 
+- Using nested lists in build/runtime inputs in `mkDerivation` is now deprecated.
+
 ### Additions and Improvements {#sec-nixpkgs-release-26.05-lib-additions-improvements}
 
 - The builder `php.buildComposerProject2` for PHP applications has been improved for better reliability and stability.

pkgs/applications/misc/makehuman/default.nix

@@ -55,9 +55,7 @@ stdenv.mkDerivation rec {
     qtbase
   ];
 
-  propagatedBuildInputs = [
-    pydeps
-  ];
+  propagatedBuildInputs = pydeps;
 
   finalSource = "${pname}-final";
 

pkgs/applications/networking/instant-messengers/gajim/default.nix

@@ -113,10 +113,10 @@ python3.pkgs.buildPythonApplication rec {
       sqlalchemy
       emoji
       httpx
-      httpx.optional-dependencies.socks
       h2
       truststore
     ]
+    ++ httpx.optional-dependencies.socks
     ++ lib.optionals enableE2E [
       pycrypto
       python-gnupg

pkgs/by-name/_1/_1password-cli/package.nix

@@ -51,7 +51,7 @@ stdenv.mkDerivation {
     versionCheckHook
   ]
   ++ lib.optional stdenv.hostPlatform.isLinux autoPatchelfHook
-  ++ lib.optional stdenv.hostPlatform.isDarwin [
+  ++ lib.optionals stdenv.hostPlatform.isDarwin [
     xar
     cpio
   ];

pkgs/by-name/aw/aws-sam-cli/package.nix

@@ -67,22 +67,25 @@ python3.pkgs.buildPythonApplication rec {
       tzlocal
       watchdog
     ]
-    ++ (with python3.pkgs.boto3-stubs.optional-dependencies; [
-      apigateway
-      cloudformation
-      ecr
-      iam
-      kinesis
-      lambda
-      s3
-      schemas
-      secretsmanager
-      signer
-      sqs
-      stepfunctions
-      sts
-      xray
-    ]);
+    ++ (
+      with python3.pkgs.boto3-stubs.optional-dependencies;
+      lib.concatLists [
+        apigateway
+        cloudformation
+        ecr
+        iam
+        kinesis
+        lambda
+        s3
+        schemas
+        secretsmanager
+        signer
+        sqs
+        stepfunctions
+        sts
+        xray
+      ]
+    );
 
   patches = [
     # Remove after aws-sam-cli > 1.154.0

pkgs/by-name/ba/basedpyright/package.nix

@@ -40,7 +40,7 @@ buildNpmPackage rec {
     docify
     pkg-config
   ]
-  ++ lib.optional stdenv.hostPlatform.isDarwin [ clang_20 ]; # clang_21 breaks keytar
+  ++ lib.optional stdenv.hostPlatform.isDarwin clang_20; # clang_21 breaks keytar
 
   buildInputs = [ libsecret ];
 

pkgs/by-name/br/browsr/package.nix

@@ -46,7 +46,7 @@ python3Packages.buildPythonApplication (finalAttrs: {
       textual
       textual-universal-directorytree
     ]
-    ++ lib.attrVals extras finalAttrs.passthru.optional-dependencies;
+    ++ lib.flatten (lib.attrVals extras finalAttrs.passthru.optional-dependencies);
 
   optional-dependencies = with python3Packages; {
     all = [

pkgs/by-name/ca/caja-with-extensions/package.nix

@@ -26,7 +26,7 @@ stdenv.mkDerivation {
   ];
 
   buildInputs =
-    lib.forEach selectedExtensions (x: x.buildInputs)
+    lib.concatMap (x: x.buildInputs) selectedExtensions
     ++ selectedExtensions
     ++ [ caja ]
     ++ caja.buildInputs;

pkgs/by-name/cd/cdxgen/package.nix

@@ -30,9 +30,7 @@ stdenv.mkDerivation (finalAttrs: {
     pnpm_10
     python3 # required for sqlite3 bindings
   ]
-  ++ lib.optional stdenv.hostPlatform.isDarwin [
-    cctools.libtool
-  ];
+  ++ lib.optional stdenv.hostPlatform.isDarwin cctools.libtool;
 
   pnpmDeps = fetchPnpmDeps {
     inherit (finalAttrs) pname version src;

pkgs/by-name/et/etesync-dav/package.nix

@@ -27,17 +27,19 @@ python3Packages.buildPythonApplication (finalAttrs: {
 
   pythonRelaxDeps = [ "radicale" ];
 
-  dependencies = with python3Packages; [
-    appdirs
-    etebase
-    etesync
-    flask
-    flask-wtf
-    msgpack
-    (python3Packages.toPythonModule (radicale.override { python3 = python; }))
-    requests
-    requests.optional-dependencies.socks
-  ];
+  dependencies =
+    with python3Packages;
+    [
+      appdirs
+      etebase
+      etesync
+      flask
+      flask-wtf
+      msgpack
+      (python3Packages.toPythonModule (radicale.override { python3 = python; }))
+      requests
+    ]
+    ++ requests.optional-dependencies.socks;
 
   doCheck = false;
 

pkgs/by-name/fa/fastnlo-toolkit/package.nix

@@ -48,13 +48,11 @@ stdenv.mkDerivation (finalAttrs: {
   ++ lib.optional withPython python
   ++ lib.optional (withPython && python.isPy3k) ncurses;
 
-  propagatedNativeBuildInputs = lib.optional withPython [ swig ];
+  propagatedNativeBuildInputs = lib.optional withPython swig;
   propagatedBuildInputs = [
     zlib
   ]
-  ++ lib.optional withPython [
-    python.pkgs.distutils
-  ];
+  ++ lib.optional withPython python.pkgs.distutils;
 
   preConfigure = ''
     substituteInPlace ./fastnlotoolkit/Makefile.in \

pkgs/by-name/gn/gnome-panel/wrapper.nix

@@ -34,7 +34,7 @@ stdenv.mkDerivation {
   ];
 
   buildInputs =
-    selectedPanelModulePackages ++ lib.forEach selectedPanelModulePackages (x: x.buildInputs or [ ]);
+    selectedPanelModulePackages ++ lib.concatMap (x: x.buildInputs or [ ]) selectedPanelModulePackages;
 
   dontUnpack = true;
   dontConfigure = true;

pkgs/by-name/gr/grap/package.nix

@@ -38,9 +38,9 @@ python3Packages.buildPythonApplication rec {
   ];
 
   buildInputs = [
-    boost183.all
     libseccomp
-  ];
+  ]
+  ++ boost183.all;
 
   strictDeps = true;
 

pkgs/by-name/gr/groonga/package.nix

@@ -51,7 +51,7 @@ stdenv.mkDerivation (finalAttrs: {
   ++ lib.optionals lz4Support [
     lz4
   ]
-  ++ lib.optional zlibSupport [
+  ++ lib.optionals zlibSupport [
     zlib
   ]
   ++ lib.optionals suggestSupport [

pkgs/by-name/is/isrcsubmit/package.nix

@@ -35,9 +35,7 @@ python3Packages.buildPythonApplication {
       musicbrainzngs
       discid
     ]
-    ++ lib.optional withKeyring [
-      keyring
-    ];
+    ++ lib.optional withKeyring keyring;
 
   pythonImportsCheck = [ "isrcsubmit" ];
 

pkgs/by-name/ji/jinja2-cli/package.nix

@@ -37,7 +37,7 @@ python3.pkgs.buildPythonApplication rec {
     [
       jinja2
     ]
-    ++ lib.attrVals extras optional-dependencies;
+    ++ lib.flatten (lib.attrVals extras optional-dependencies);
 
   pythonImportsCheck = [ "jinja2cli" ];
 

pkgs/by-name/ki/kitsas/package.nix

@@ -32,9 +32,7 @@ stdenv.mkDerivation (finalAttrs: {
     qt6.qtsvg
     qt6.qtwebengine
   ]
-  ++ lib.optional stdenv.hostPlatform.isLinux [
-    qt6.qtwayland
-  ];
+  ++ lib.optional stdenv.hostPlatform.isLinux qt6.qtwayland;
 
   # We use a separate build-dir as otherwise ld seems to get confused between
   # directory and executable name on buildPhase.

pkgs/by-name/la/ladybird/package.nix

@@ -131,7 +131,7 @@ stdenv.mkDerivation (finalAttrs: {
     icu78
     simdjson
   ]
-  ++ lib.optional stdenv.hostPlatform.isLinux [
+  ++ lib.optionals stdenv.hostPlatform.isLinux [
     libpulseaudio.dev
     qt6Packages.qtwayland
   ];

pkgs/by-name/li/libass/package.nix

@@ -45,9 +45,8 @@ stdenv.mkDerivation (finalAttrs: {
     harfbuzz
   ]
   ++ lib.optional fontconfigSupport fontconfig
-  ++ lib.optional stdenv.hostPlatform.isDarwin [
-    libiconv
-  ];
+  # TODO: remove dep after branchoff (in darwin stdenv)
+  ++ lib.optional stdenv.hostPlatform.isDarwin libiconv.out;
 
   meta = {
     description = "Portable ASS/SSA subtitle renderer";

pkgs/by-name/mc/mcrl2/package.nix

@@ -56,7 +56,7 @@ stdenv.mkDerivation rec {
     qt6.qtbase
     boost
   ]
-  ++ lib.optional stdenv.hostPlatform.isDarwin [ makeWrapper ];
+  ++ lib.optional stdenv.hostPlatform.isDarwin makeWrapper;
 
   dontWrapQtApps = true;
 

pkgs/by-name/mo/modrinth-app-unwrapped/package.nix

@@ -91,7 +91,7 @@ rustPlatform.buildRustPackage (finalAttrs: {
     pnpmConfigHook
     pnpm_10
   ]
-  ++ lib.optional stdenv.hostPlatform.isDarwin [
+  ++ lib.optionals stdenv.hostPlatform.isDarwin [
     makeBinaryWrapper
     xcbuild
   ];

pkgs/by-name/mu/music-assistant/package.nix

@@ -177,7 +177,7 @@ python.pkgs.buildPythonApplication rec {
       pytestCheckHook
     ]
     ++ lib.concatAttrValues optional-dependencies
-    ++ (map (provider: providerPackages.${provider} python.pkgs) [
+    ++ (lib.concatMap (provider: providerPackages.${provider} python.pkgs) [
       "audible"
       "dlna"
       "jellyfin"

pkgs/by-name/n8/n8n/package.nix

@@ -50,7 +50,7 @@ stdenv.mkDerivation (finalAttrs: {
     makeWrapper
     dart-sass
   ]
-  ++ lib.optional stdenv.hostPlatform.isDarwin [
+  ++ lib.optionals stdenv.hostPlatform.isDarwin [
     cctools
     xcbuild
   ];

pkgs/by-name/ni/nix-unit/package.nix

@@ -48,7 +48,7 @@ stdenv.mkDerivation (finalAttrs: {
     # nlohmann_json can be only discovered via cmake files
     cmake
   ]
-  ++ lib.optional stdenv.cc.isClang [ clang-tools ];
+  ++ lib.optional stdenv.cc.isClang clang-tools;
 
   postInstall = ''
     wrapProgram "$out/bin/nix-unit" --prefix PATH : ${difftastic}/bin

pkgs/by-name/no/novops/package.nix

@@ -25,7 +25,7 @@ rustPlatform.buildRustPackage (finalAttrs: {
   buildInputs = [
     openssl # required for openssl-sys
   ]
-  ++ lib.optional stdenv.hostPlatform.isDarwin [
+  ++ lib.optionals stdenv.hostPlatform.isDarwin [
     libiconv
   ];
 

pkgs/by-name/ol/ollama/package.nix

@@ -168,10 +168,12 @@ goBuild (finalAttrs: {
     cmake
     gitMinimal
   ]
-  ++ lib.optionals enableRocm [
-    rocmPackages.llvm.bintools
+  ++ lib.optionals enableRocm (
     rocmLibs
-  ]
+    ++ [
+      rocmPackages.llvm.bintools
+    ]
+  )
   ++ lib.optionals enableCuda [ cudaPackages.cuda_nvcc ]
   ++ lib.optionals (enableRocm || enableCuda) [
     makeBinaryWrapper

pkgs/by-name/pa/pat/package.nix

@@ -27,7 +27,7 @@ buildGoModule (finalAttrs: {
 
   nativeBuildInputs = [ installShellFiles ];
 
-  buildInputs = lib.optional stdenv.hostPlatform.isLinux [ libax25 ];
+  buildInputs = lib.optional stdenv.hostPlatform.isLinux libax25;
 
   # Needed by wl2k-go go module for libax25 to include support for Linux' AX.25 stack by linking against libax25.
   # ref: https://github.com/la5nta/wl2k-go/blob/abe3ae5bf6a2eec670a21672d461d1c3e1d4c2f3/transport/ax25/ax25.go#L11-L17

pkgs/by-name/pa/patroni/package.nix

@@ -50,7 +50,7 @@ python3Packages.buildPythonApplication (finalAttrs: {
       urllib3
       ydiff
     ])
-    ++ lib.attrVals extras finalAttrs.passthru.optional-dependencies;
+    ++ lib.flatten (lib.attrVals extras finalAttrs.passthru.optional-dependencies);
 
   optional-dependencies = with python3Packages; {
     aws = [ boto3 ];

pkgs/by-name/pe/persepolis/package.nix

@@ -40,8 +40,9 @@ python3.pkgs.buildPythonApplication (finalAttrs: {
     "\${qtWrapperArgs[@]}"
   ];
 
-  propagatedBuildInputs = [
-    (with python3.pkgs; [
+  propagatedBuildInputs = (
+    with python3.pkgs;
+    [
       psutil
       pyside6
       pysocks
@@ -51,8 +52,8 @@ python3.pkgs.buildPythonApplication (finalAttrs: {
       setproctitle
       setuptools
       yt-dlp
-    ])
-  ];
+    ]
+  );
 
   meta = {
     description = "Download manager GUI written in Python";

pkgs/by-name/pv/pvzge/package.nix

@@ -34,7 +34,7 @@ stdenvNoCC.mkDerivation (finalAttrs: {
     makeWrapper
     imagemagick
   ]
-  ++ lib.optional stdenvNoCC.hostPlatform.isDarwin [ desktopToDarwinBundle ];
+  ++ lib.optional stdenvNoCC.hostPlatform.isDarwin desktopToDarwinBundle;
 
   postPatch = ''
     sed -i "s|<title>.*</title>|<title>PvZ2: Gardendless</title>|" docs/index.html

pkgs/by-name/py/pympress/package.nix

@@ -37,9 +37,7 @@ python3Packages.buildPythonApplication (finalAttrs: {
       pycairo
       pygobject3
     ]
-    ++ lib.optional withVLC [
-      python-vlc
-    ];
+    ++ lib.optional withVLC python-vlc;
 
   nativeBuildInputs = [
     wrapGAppsHook3

pkgs/by-name/re/redo-apenwarr/package.nix

@@ -66,11 +66,9 @@ stdenv.mkDerivation (finalAttrs: {
 
   nativeBuildInputs = [
     python3
-    (with python3.pkgs; [
-      beautifulsoup4
-      markdown
-    ])
     which
+    python3.pkgs.beautifulsoup4
+    python3.pkgs.markdown
     installShellFiles
     gnumake42 # fails with make 4.4
   ];

pkgs/by-name/re/renovate/package.nix

@@ -42,7 +42,7 @@ stdenv.mkDerivation (finalAttrs: {
     python3
     yq-go
   ]
-  ++ lib.optional stdenv.hostPlatform.isDarwin [
+  ++ lib.optionals stdenv.hostPlatform.isDarwin [
     xcbuild
     cctools # contains libtool, required by better-sqlite3
   ];

pkgs/by-name/ry/ryubing/package.nix

@@ -43,10 +43,8 @@ buildDotnetModule rec {
   };
 
   nativeBuildInputs =
-    lib.optional stdenv.hostPlatform.isLinux [
-      wrapGAppsHook3
-    ]
-    ++ lib.optional stdenv.hostPlatform.isDarwin [
+    lib.optional stdenv.hostPlatform.isLinux wrapGAppsHook3
+    ++ lib.optionals stdenv.hostPlatform.isDarwin [
       cctools
       darwin.sigtool
     ];
@@ -82,11 +80,11 @@ buildDotnetModule rec {
     libGL
     SDL2
   ]
-  ++ lib.optional (!stdenv.hostPlatform.isDarwin) [
+  ++ lib.optionals (!stdenv.hostPlatform.isDarwin) [
     udev
     pulseaudio
   ]
-  ++ lib.optional stdenv.hostPlatform.isDarwin [ moltenvk ];
+  ++ lib.optional stdenv.hostPlatform.isDarwin moltenvk;
 
   projectFile = "Ryujinx.sln";
   testProjectFile = "src/Ryujinx.Tests/Ryujinx.Tests.csproj";

pkgs/by-name/sh/shairport-sync/package.nix

@@ -75,7 +75,7 @@ stdenv.mkDerivation (finalAttrs: {
     # mkDerivation's splicing logic from kicking in.
     "${glib.dev}"
   ]
-  ++ optional enableAirplay2 [
+  ++ optionals enableAirplay2 [
     libplist.bin
     unixtools.xxd
   ];

pkgs/by-name/so/sope/package.nix

@@ -23,7 +23,7 @@ clangStdenv.mkDerivation rec {
     hash = "sha256-0G28qDXygDe/TJ2znNE+NVQry3bkqUO59jqtJm/t2S4=";
   };
 
-  nativeBuildInputs = lib.optional (libpq != null) [ libpq.pg_config ];
+  nativeBuildInputs = lib.optional (libpq != null) libpq.pg_config;
   buildInputs = [
     gnustep-base
     libxml2

pkgs/by-name/st/streamlink/package.nix

@@ -58,7 +58,7 @@ python3Packages.buildPythonApplication rec {
       urllib3
       websocket-client
     ]
-    ++ lib.attrVals extras optional-dependencies;
+    ++ lib.flatten (lib.attrVals extras optional-dependencies);
 
   optional-dependencies = with python3Packages; {
     decompress = urllib3.optional-dependencies.brotli ++ urllib3.optional-dependencies.zstd;

pkgs/by-name/te/terminusdb/package.nix

@@ -105,10 +105,8 @@ stdenv.mkDerivation (finalAttrs: {
   strictDeps = true;
 
   nativeBuildInputs = [
-    (with rustPlatform; [
-      cargoSetupHook
-      bindgenHook # provides libclang
-    ])
+    rustPlatform.cargoSetupHook
+    rustPlatform.bindgenHook # provides libclang
     cargo
     installShellFiles
     protobuf

pkgs/by-name/ti/tigervnc/package.nix

@@ -209,7 +209,7 @@ stdenv.mkDerivation (finalAttrs: {
     ]
   );
 
-  propagatedBuildInputs = lib.optional stdenv.hostPlatform.isLinux xorg-server.propagatedBuildInputs;
+  propagatedBuildInputs = lib.optionals stdenv.hostPlatform.isLinux xorg-server.propagatedBuildInputs;
 
   passthru.tests.tigervnc = nixosTests.tigervnc;
 

pkgs/by-name/tu/turses/package.nix

@@ -22,10 +22,12 @@ let
           tag = "v${version}";
           hash = "sha256-3BbQeCaAhlz9h5GnhficNubJHu4kTpnCDM4oKzlti0w=";
         };
-        dependencies = oldAttrs.dependencies ++ [
-          super.six
-          super.requests.optional-dependencies.socks
-        ];
+        dependencies =
+          oldAttrs.dependencies
+          ++ [
+            super.six
+          ]
+          ++ super.requests.optional-dependencies.socks;
         doCheck = false;
       });
     };

pkgs/by-name/vc/vcv-rack/package.nix

@@ -123,7 +123,7 @@ let
       libjack2
       libpulseaudio
     ]
-    ++ lib.optional stdenv.hostPlatform.isDarwin [ apple-sdk_14 ];
+    ++ lib.optional stdenv.hostPlatform.isDarwin apple-sdk_14;
 
     cmakeFlags = [
       (lib.cmakeBool "RTAUDIO_API_ALSA" stdenv.hostPlatform.isLinux)

pkgs/by-name/vo/voxtype/package.nix

@@ -82,7 +82,7 @@ rustPlatform.buildRustPackage (finalAttrs: {
     makeBinaryWrapper
     pkg-config
   ]
-  ++ lib.optional vulkanSupport [
+  ++ lib.optionals vulkanSupport [
     shaderc
     vulkan-headers
     vulkan-loader

pkgs/by-name/wh/whoogle-search/package.nix

@@ -18,44 +18,46 @@ python3Packages.buildPythonApplication (finalAttrs: {
 
   build-system = with python3Packages; [ setuptools ];
 
-  dependencies = with python3Packages; [
-    attrs
-    beautifulsoup4
-    brotli
-    cachetools
-    certifi
-    cffi
-    click
-    cryptography
-    cssutils
-    defusedxml
-    flask
-    h11
-    httpcore
-    httpx
-    httpx.optional-dependencies.http2
-    httpx.optional-dependencies.socks
-    idna
-    itsdangerous
-    jinja2
-    markupsafe
-    more-itertools
-    packaging
-    pluggy
-    pycodestyle
-    pycparser
-    pyopenssl
-    pyparsing
-    pytest
-    python-dateutil
-    python-dotenv
-    soupsieve
-    stem
-    validators
-    waitress
-    wcwidth
-    werkzeug
-  ];
+  dependencies =
+    with python3Packages;
+    [
+      attrs
+      beautifulsoup4
+      brotli
+      cachetools
+      certifi
+      cffi
+      click
+      cryptography
+      cssutils
+      defusedxml
+      flask
+      h11
+      httpcore
+      httpx
+      idna
+      itsdangerous
+      jinja2
+      markupsafe
+      more-itertools
+      packaging
+      pluggy
+      pycodestyle
+      pycparser
+      pyopenssl
+      pyparsing
+      pytest
+      python-dateutil
+      python-dotenv
+      soupsieve
+      stem
+      validators
+      waitress
+      wcwidth
+      werkzeug
+    ]
+    ++ httpx.optional-dependencies.http2
+    ++ httpx.optional-dependencies.socks;
 
   postInstall = ''
     # This creates renamed versions of the static files for cache busting,

pkgs/by-name/wt/wtfutil/package.nix

@@ -47,7 +47,7 @@ buildGoModule (finalAttrs: {
 
   doInstallCheck = true;
   # Darwin Error: mkdir /var/empty: file exists
-  nativeInstallCheckInputs = lib.optional (!stdenv.hostPlatform.isDarwin) [ versionCheckHook ];
+  nativeInstallCheckInputs = lib.optional (!stdenv.hostPlatform.isDarwin) versionCheckHook;
 
   passthru.updateScript = nix-update-script { };
 

pkgs/by-name/xp/xpra/package.nix

@@ -188,7 +188,7 @@ effectiveBuildPythonApplication rec {
     xxhash
     systemd
   ]
-  ++ lib.optional withNvenc [
+  ++ lib.optionals withNvenc [
     nvencHeaders
     nvjpegHeaders
   ];

pkgs/by-name/yc/ycmd/package.nix

@@ -43,10 +43,10 @@ stdenv.mkDerivation {
     [
       abseil-cpp
       boost
-      libllvm.all
-      libclang.all
       legacy-cgi
     ]
+    ++ libllvm.all
+    ++ libclang.all
     ++ [
       jedi
       jedi-language-server

pkgs/desktops/pantheon/apps/switchboard/wrapper.nix

@@ -40,7 +40,7 @@ stdenv.mkDerivation {
     wrapGAppsHook4
   ];
 
-  buildInputs = lib.forEach selectedPlugs (x: x.buildInputs) ++ selectedPlugs;
+  buildInputs = lib.concatMap (x: x.buildInputs) selectedPlugs ++ selectedPlugs;
 
   dontUnpack = true;
   dontConfigure = true;

pkgs/desktops/pantheon/desktop/wingpanel/wrapper.nix

@@ -37,7 +37,7 @@ stdenv.mkDerivation {
     wrapGAppsHook3
   ];
 
-  buildInputs = lib.forEach selectedIndicators (x: x.buildInputs) ++ selectedIndicators;
+  buildInputs = lib.concatMap (x: x.buildInputs) selectedIndicators ++ selectedIndicators;
 
   dontUnpack = true;
   dontConfigure = true;

pkgs/development/compilers/dotnet/wrapper.nix

@@ -223,7 +223,7 @@ stdenvNoCC.mkDerivation (finalAttrs: {
               buildInputs = [
                 zlib
               ]
-              ++ lib.optional stdenv.hostPlatform.isDarwin [
+              ++ lib.optionals stdenv.hostPlatform.isDarwin [
                 swiftPackages.swift
                 darwin.ICU
               ];

pkgs/development/haskell-modules/configuration-common.nix

@@ -1572,7 +1572,7 @@ with haskellLib;
   # https://github.com/mgajda/json-autotype/issues/25
   json-autotype = dontCheck super.json-autotype;
 
-  gargoyle-postgresql-nix = addBuildTool [ pkgs.postgresql ] super.gargoyle-postgresql-nix;
+  gargoyle-postgresql-nix = addBuildTool pkgs.postgresql super.gargoyle-postgresql-nix;
 
   # PortMidi needs an environment variable to have ALSA find its plugins:
   # https://github.com/NixOS/nixpkgs/issues/6860

pkgs/development/mobile/androidenv/tools.nix

@@ -17,7 +17,7 @@ deployAndroidPackage {
   name = "androidsdk-tools";
   inherit package os arch;
   nativeBuildInputs = [ makeWrapper ] ++ lib.optionals (os == "linux") [ autoPatchelfHook ];
-  buildInputs = lib.optional (os == "linux") (
+  buildInputs = lib.optionals (os == "linux") (
     (with pkgs; [
       glibc
       freetype

pkgs/development/octave-modules/io/default.nix

@@ -16,9 +16,7 @@ buildOctavePackage rec {
     sha256 = "sha256-G49gAZ/lzir1YwEAPjBGRjNJ3VMxI+iXnsS0yev8f2s=";
   };
 
-  buildInputs = [
-    (lib.optional enableJava jdk)
-  ];
+  buildInputs = lib.optional enableJava jdk;
 
   propagatedBuildInputs = [
     unzip

pkgs/development/python-modules/drf-pydantic/default.nix

@@ -35,8 +35,8 @@ buildPythonPackage rec {
   nativeCheckInputs = [
     pytestCheckHook
     pytest-cov-stub
-    pydantic.optional-dependencies.email
-  ];
+  ]
+  ++ pydantic.optional-dependencies.email;
 
   meta = {
     changelog = "https://github.com/georgebv/drf-pydantic/releases/tag/${src.tag}";

pkgs/development/python-modules/e3-core/default.nix

@@ -47,7 +47,7 @@ buildPythonPackage rec {
     stevedore
     tqdm
   ]
-  ++ lib.optional stdenv.hostPlatform.isLinux [
+  ++ lib.optionals stdenv.hostPlatform.isLinux [
     # See https://github.com/AdaCore/e3-core/blob/v22.6.0/pyproject.toml#L37-L42
     # These are required only on Linux. Darwin has its own set of requirements
     psutil

pkgs/development/python-modules/eth-keys/default.nix

@@ -46,8 +46,8 @@ buildPythonPackage rec {
     pydantic
   ]
   ++ optional-dependencies.coincurve
-  ++ lib.optional (!isPyPy) eth-hash.optional-dependencies.pysha3
-  ++ lib.optional isPyPy eth-hash.optional-dependencies.pycryptodome;
+  ++ lib.optionals (!isPyPy) eth-hash.optional-dependencies.pysha3
+  ++ lib.optionals isPyPy eth-hash.optional-dependencies.pycryptodome;
 
   pythonImportsCheck = [ "eth_keys" ];
 

pkgs/development/python-modules/langchain-aws/default.nix

@@ -62,8 +62,7 @@ buildPythonPackage (finalAttrs: {
   ];
 
   optional-dependencies = {
-    anthropic = [
-      anthropic.optional-dependencies.bedrock
+    anthropic = anthropic.optional-dependencies.bedrock ++ [
       langchain-anthropic
     ];
   };

pkgs/development/python-modules/mayim/default.nix

@@ -44,11 +44,14 @@ buildPythonPackage rec {
     pytest-asyncio
     pytest-cov-stub
   ]
-  ++ (with optional-dependencies; [
-    postgres
-    mysql
-    sqlite
-  ]);
+  ++ (
+    with optional-dependencies;
+    lib.concatLists [
+      postgres
+      mysql
+      sqlite
+    ]
+  );
 
   pythonImportsCheck = [ "mayim" ];
 

pkgs/development/python-modules/shiboken6/default.nix

@@ -34,9 +34,7 @@ stdenv'.mkDerivation (finalAttrs: {
   buildInputs = [
     python.pkgs.qt6.qtbase
   ]
-  ++ lib.optionals stdenv.hostPlatform.isDarwin [
-    python.pkgs.qt6.darwinVersionInputs
-  ];
+  ++ lib.optionals stdenv.hostPlatform.isDarwin python.pkgs.qt6.darwinVersionInputs;
 
   cmakeFlags = [
     "-DBUILD_TESTS=OFF"

pkgs/development/python-modules/swh-core/default.nix

@@ -101,7 +101,6 @@ buildPythonPackage (finalAttrs: {
     msgpack
     postgresql
     postgresqlTestHook
-    psycopg.optional-dependencies.pool
     pylzma
     pytestCheckHook
     pytest-aiohttp
@@ -119,7 +118,8 @@ buildPythonPackage (finalAttrs: {
     types-requests
     unzip
     pkgs.zstd
-  ];
+  ]
+  ++ psycopg.optional-dependencies.pool;
 
   disabledTestPaths = lib.optionals (pythonAtLeast "3.14") [
     # shutil.RegistryError: .tar.zst is already registered for "zstdtar"

pkgs/development/python-modules/uptime-kuma-api/default.nix

@@ -20,8 +20,8 @@ buildPythonPackage rec {
   propagatedBuildInputs = [
     packaging
     python-socketio
-    python-socketio.optional-dependencies.client
-  ];
+  ]
+  ++ python-socketio.optional-dependencies.client;
 
   pythonImportsCheck = [ "uptime_kuma_api" ];
 

pkgs/development/ruby-modules/with-packages/default.nix

@@ -77,9 +77,9 @@ let
       name = "${ruby.name}-with-packages";
       nativeBuildInputs = [ makeBinaryWrapper ];
       buildInputs = [
-        selected
         ruby
-      ];
+      ]
+      ++ selected;
 
       dontUnpack = true;
 

pkgs/development/tools/godot/common.nix

@@ -620,7 +620,7 @@ let
           scons
         ]
         ++ lib.optionals withWayland [ wayland-scanner ]
-        ++ lib.optional (editor && withMono) [
+        ++ lib.optionals (editor && withMono) [
           makeWrapper
           dotnet-sdk
         ]

pkgs/os-specific/linux/drbd/driver.nix

@@ -21,8 +21,7 @@ stdenv.mkDerivation (finalAttrs: {
 
   hardeningDisable = [ "pic" ];
 
-  nativeBuildInputs = [
-    kernel.moduleBuildDependencies
+  nativeBuildInputs = kernel.moduleBuildDependencies ++ [
     flex
     coccinelle
     python3

pkgs/servers/home-assistant/tests.nix

@@ -6,10 +6,11 @@
 
 let
   getComponentDeps = component: home-assistant.getPackages component home-assistant.python.pkgs;
+  inherit (lib) concatMap;
 
   # some components' tests have additional dependencies
   extraCheckInputs = with home-assistant.python.pkgs; {
-    alexa = map getComponentDeps [
+    alexa = concatMap getComponentDeps [
       "cloud"
       "frontend"
       "stream"
@@ -50,7 +51,7 @@ let
       pychromecast
     ];
     lutron_caseta = getComponentDeps "frontend";
-    mastodon = map getComponentDeps [
+    mastodon = concatMap getComponentDeps [
       "stream"
     ];
     miele = getComponentDeps "cloud";

pkgs/stdenv/generic/make-derivation.nix

@@ -52,6 +52,7 @@ let
     unique
     unsafeDiscardStringContext
     unsafeGetAttrPos
+    warn
     warnIf
     zipAttrsWith
     ;
@@ -482,7 +483,12 @@ let
             if isSingularDependency dep then
               index + 1
             else if isList dep then
-              seq (checkDependencyList' ([ index ] ++ positions) name dep) (index + 1)
+              warn
+                ''
+                  Dependency of package '${attrs.name or attrs.pname}' uses a nested list in attribute '${name}'.
+                  This is deprecated as of Nixpkgs release 26.05, and support will
+                  be removed in a future nixpkgs release.''
+                (seq (checkDependencyList' ([ index ] ++ positions) name dep) (index + 1))
             else
               throw "Dependency is not of a valid type: ${
                 concatMapStrings (ix: "element ${toString ix} of ") ([ index ] ++ positions)

pkgs/tools/package-management/lix/common-nix-eval-jobs.nix

@@ -40,7 +40,7 @@ stdenv.mkDerivation {
     # nlohmann_json can be only discovered via cmake files
     cmake
   ]
-  ++ (lib.optional stdenv.cc.isClang [ buildPackages.clang-tools ]);
+  ++ (lib.optional stdenv.cc.isClang buildPackages.clang-tools);
 
   # point 'nix edit' and ofborg at the file that defines the attribute,
   # not this common file.