{amazon,sd,disk-image,openstack}-image: Fix image.filePath, image.extensions (#409571)

nixos/maintainers/scripts/ec2/amazon-image.nix

@@ -88,7 +88,7 @@ in
 
   config.system.nixos.tags = [ "amazon" ];
   config.system.build.image = config.system.build.amazonImage;
-  config.image.extension = cfg.format;
+  config.image.extension = if cfg.format == "vpc" then "vhd" else cfg.format;
 
   config.system.build.amazonImage =
     let

nixos/maintainers/scripts/openstack/openstack-image-zfs.nix

@@ -113,7 +113,7 @@ in
       postVM = ''
          extension=''${rootDiskImage##*.}
          friendlyName=$out/${config.image.baseName}
-         rootDisk="$friendlyName.root.$extension"
+         rootDisk="$friendlyName.$extension"
          mv "$rootDiskImage" "$rootDisk"
 
          mkdir -p $out/nix-support

nixos/modules/installer/sd-card/sd-image.nix

@@ -205,7 +205,7 @@ in
     sdImage.storePaths = [ config.system.build.toplevel ];
 
     image.extension = if config.sdImage.compressImage then "img.zst" else "img";
-    image.filePath = "sd-card/${config.image.fileName}";
+    image.filePath = "sd-image/${config.image.fileName}";
     system.nixos.tags = [ "sd-card" ];
     system.build.image = config.system.build.sdImage;
     system.build.sdImage = pkgs.callPackage (

nixos/modules/virtualisation/disk-image.nix

@@ -50,7 +50,7 @@ in
     };
 
     system.nixos.tags = [ cfg.format ] ++ lib.optionals cfg.efiSupport [ "efi" ];
-    image.extension = cfg.format;
+    image.extension = if cfg.format == "raw" then "img" else cfg.format;
     system.build.image = import ../../lib/make-disk-image.nix {
       inherit lib config pkgs;
       inherit (config.virtualisation) diskSize;