sinit: migrate to by-name, modernize derivation (#511793)

pkgs/by-name/si/sinit/package.nix

@@ -2,19 +2,19 @@
   lib,
   stdenv,
   fetchgit,
-  rcinit ? null,
-  rcshutdown ? null,
+  rcinit ? "/etc/rc.d/rc.init",
+  rcshutdown ? "/etc/rc.d/rc.shutdown",
   rcreboot ? null,
 }:
 
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "sinit";
   version = "1.1";
 
   src = fetchgit {
     url = "https://git.suckless.org/sinit/";
-    sha256 = "sha256-VtXkgixgElKKOT26uKN9feXDVjjtSgTWvcgk5o5MLmw=";
-    tag = "v${version}";
+    hash = "sha256-VtXkgixgElKKOT26uKN9feXDVjjtSgTWvcgk5o5MLmw=";
+    tag = "v${finalAttrs.version}";
   };
   buildInputs = [
     (lib.getOutput "static" stdenv.cc.libc)
@@ -41,4 +41,4 @@ stdenv.mkDerivation rec {
     homepage = "https://tools.suckless.org/sinit";
     downloadPage = "https://git.suckless.org/sinit";
   };
-}
+})

pkgs/top-level/all-packages.nix

@@ -8608,11 +8608,6 @@ with pkgs;
     protobuf = protobuf_33;
   };
 
-  sinit = callPackage ../os-specific/linux/sinit {
-    rcinit = "/etc/rc.d/rc.init";
-    rcshutdown = "/etc/rc.d/rc.shutdown";
-  };
-
   sysdig = callPackage ../os-specific/linux/sysdig {
     kernel = null;
   }; # sysdig is a client, for a driver look at linuxPackagesFor