python313Packages.splinter: fix build with lxml 6 (#465719)

2025-11-29 21:34:05 +00:00
parent 60be56a193 98d1634423
commit 7f8ccd8fe6
2 changed files with 51 additions and 9 deletions
@@ -1,7 +1,6 @@
 {
  lib,
  buildPythonPackage,
-  pythonOlder,
  fetchFromGitHub,
  setuptools,
  urllib3,
@@ -17,9 +16,6 @@
 buildPythonPackage rec {
  pname = "splinter";
  version = "0.21.0";
-
-  disabled = pythonOlder "3.8";
-
  pyproject = true;

  src = fetchFromGitHub {
@@ -29,9 +25,13 @@ buildPythonPackage rec {
    hash = "sha256-PGGql8yI1YosoUBAyDoI/8k7s4sVYnXEV7eow3GHH88=";
  };

-  nativeBuildInputs = [ setuptools ];
+  patches = [
+    ./lxml-6.patch
+  ];

-  propagatedBuildInputs = [ urllib3 ];
+  build-system = [ setuptools ];
+
+  dependencies = [ urllib3 ];

  optional-dependencies = {
    "zope.testbrowser" = [
@@ -84,11 +84,11 @@ buildPythonPackage rec {

  pythonImportsCheck = [ "splinter" ];

-  meta = with lib; {
+  meta = {
    changelog = "https://splinter.readthedocs.io/en/latest/news.html";
    description = "Browser abstraction for web acceptance testing";
    homepage = "https://github.com/cobrateam/splinter";
-    license = licenses.bsd3;
-    maintainers = with maintainers; [ dotlambda ];
+    license = lib.licenses.bsd3;
+    maintainers = with lib.maintainers; [ dotlambda ];
  };
 }
@@ -0,0 +1,42 @@
+diff --git a/tests/fake_django/urls.py b/tests/fake_django/urls.py
+index 2ab75ff..bd736ab 100644
+--- a/tests/fake_django/urls.py
+++ b/tests/fake_django/urls.py
+@@ -52,7 +52,8 @@ def post_form(request):
+ 
+ 
+ def request_headers(request):
+-    body = "\n".join(f"{key}: {value}" for key, value in request.META.items())
+    headers = "\n".join(f"{key}: {value}" for key, value in request.META.items())
+    body = f"<html><body>{headers}</body></html>"
+     return HttpResponse(body)
+ 
+ 
+@@ -67,7 +68,7 @@ def upload_file(request):
+ 
+ 
+ def foo(request):
+-    return HttpResponse("BAR!")
+    return HttpResponse("<html><body>BAR!</body></html>")
+ 
+ 
+ def query_string(request):
+diff --git a/tests/fake_webapp.py b/tests/fake_webapp.py
+index ccd5bab..efc31c5 100644
+--- a/tests/fake_webapp.py
+++ b/tests/fake_webapp.py
+@@ -119,12 +119,12 @@ def upload_file():
+ 
+ @app.route("/headers", methods=["GET"])
+ def request_headers():
+-    return str(request.headers)
+    return f"<html><body>{request.headers}</body></html>"
+ 
+ 
+ @app.route("/foo")
+ def foo():
+-    return "BAR!"
+    return "<html><body>BAR!</body></html>"
+ 
+ 
+ @app.route("/query", methods=["GET"])