golden-cheetah{,-bin}: move icon to spec-compliant location (#495757)

pkgs/by-name/go/golden-cheetah-bin/linux.nix

@@ -27,11 +27,11 @@ appimageTools.wrapType2 rec {
   extraInstallCommands = ''
     mv $out/bin/${pname} $out/bin/GoldenCheetah
     mkdir -p $out/share/applications
-    mkdir -p $out/share/pixmaps
+    mkdir -p $out/share/icons/hicolor/512x512/apps
     cp ${appimageContents}/GoldenCheetah.desktop $out/share/applications/
     substituteInPlace $out/share/applications/GoldenCheetah.desktop --replace-fail \
       "Exec=GoldenCheetah" "Exec=env QT_PLUGIN_PATH= GoldenCheetah"
-    cp ${appimageContents}/gc.png $out/share/pixmaps/
+    cp ${appimageContents}/gc.png $out/share/icons/hicolor/512x512/apps/
   '';
   meta = {
     inherit (commonMeta)

pkgs/by-name/go/golden-cheetah/package.nix

@@ -100,7 +100,7 @@ stdenv.mkDerivation (finalAttrs: {
         mkdir -p $out/bin
         cp src/GoldenCheetah $out/bin
         install -Dm644 "${desktopItem}/share/applications/"* -t $out/share/applications/
-        install -Dm644 src/Resources/images/gc.png $out/share/pixmaps/goldencheetah.png
+        install -Dm644 src/Resources/images/gc.png $out/share/icons/hicolor/512x512/apps/goldencheetah.png
 
         runHook postInstall
       ''