ycmd: correct gopls package and link path

This fixes built-in Go completion support in vimPlugins.YouCompleteMe.

Previously both an outdated package (gotools) and an outdated binary
path were used when installing gopls into ycmd, silently breaking after an
upstream update.

Signed-off-by: Mel <einebeere@gmail.com>

pkgs/by-name/yc/ycmd/package.nix

@@ -6,8 +6,8 @@
 , python
 , withGodef ? true
 , godef
-, withGotools ? true
-, gotools
+, withGopls ? true
+, gopls
 , withRustAnalyzer ? true
 , rust-analyzer
 , withTypescript ? true
@@ -80,10 +80,10 @@ stdenv.mkDerivation {
     TARGET=$out/lib/ycmd/third_party/godef
     mkdir -p $TARGET
     ln -sf ${godef}/bin/godef $TARGET
-  '' + lib.optionalString withGotools ''
-    TARGET=$out/lib/ycmd/third_party/go/src/golang.org/x/tools/cmd/gopls
+  '' + lib.optionalString withGopls ''
+    TARGET=$out/lib/ycmd/third_party/go/bin
     mkdir -p $TARGET
-    ln -sf ${gotools}/bin/gopls $TARGET
+    ln -sf ${gopls}/bin/gopls $TARGET
   '' + lib.optionalString withRustAnalyzer ''
     TARGET=$out/lib/ycmd/third_party/rust-analyzer
     mkdir -p $TARGET