treewide: correct versionCheckHook use (#376275)

pkgs/by-name/ae/aerospace/package.nix

@@ -39,7 +39,10 @@ stdenv.mkDerivation {
     installShellCompletion --zsh  shell-completion/zsh/_aerospace
   '';
 
-  passthru.tests.can-print-version = [ versionCheckHook ];
+  doInstallCheck = true;
+  nativeInstallCheckInputs = [
+    versionCheckHook
+  ];
 
   passthru.updateScript = gitUpdater {
     url = "https://github.com/nikitabobko/AeroSpace.git";

pkgs/by-name/as/astroterm/package.nix

@@ -31,13 +31,17 @@ stdenv.mkDerivation (finalAttrs: {
     meson
     ninja
     xxd
-    versionCheckHook
   ];
   buildInputs = [
     argtable
     ncurses
   ];
 
+  doInstallCheck = true;
+  nativeInstallCheckInputs = [
+    versionCheckHook
+  ];
+
   postPatch = ''
     mkdir -p data
     ln -s ${finalAttrs.bsc5File} data/bsc5

pkgs/by-name/cl/cloudpan189-go/package.nix

@@ -22,6 +22,7 @@ buildGo122Module rec {
     '';
   };
 
+  doInstallCheck = true;
   nativeInstallCheckInputs = [
     versionCheckHook
   ];

pkgs/by-name/de/deepsource/package.nix

@@ -48,6 +48,8 @@ buildGoModule rec {
       --zsh <($out/bin/deepsource completion zsh)
   '';
 
+  doInstallCheck = true;
+  versionCheckProgramArg = [ "version" ];
   nativeInstallCheckInputs = [
     versionCheckHook
   ];

pkgs/by-name/en/envision-unwrapped/package.nix

@@ -67,7 +67,6 @@ stdenv.mkDerivation (finalAttrs: {
     pkg-config
     rustPlatform.cargoSetupHook
     rustc
-    versionCheckHook
     wrapGAppsHook4
   ];
 
@@ -87,6 +86,14 @@ stdenv.mkDerivation (finalAttrs: {
     zlib
   ];
 
+  # FIXME: error when running `env -i envision`:
+  # "HOME env var not defined: NotPresent"
+  doInstallCheck = false;
+  versionCheckProgram = "${placeholder "out"}/bin/envision";
+  nativeInstallCheckInputs = [
+    versionCheckHook
+  ];
+
   postInstall = ''
     wrapProgram $out/bin/envision \
       --prefix PATH : "${lib.makeBinPath [ gdb ]}"

pkgs/by-name/go/gollama/package.nix

@@ -16,6 +16,11 @@ buildGoModule rec {
     hash = "sha256-7wCBflX34prZJl4HhZUU2a2qHxaBs1fMKHpwE0vX1GE=";
   };
 
+  postPatch = ''
+    substituteInPlace main.go \
+      --replace-fail 'Version = "1.28.0"' 'Version = "${version}"'
+  '';
+
   vendorHash = "sha256-Y5yg54em+vqoWXxS3JVQVPEM+fLXgoblmY+48WpxSCQ=";
 
   doCheck = false;
@@ -25,7 +30,10 @@ buildGoModule rec {
     "-w"
   ];
 
-  nativeInputChecks = [
+  # FIXME: error when running `env -i gollama`:
+  # "Error initializing logging: $HOME is not defined"
+  doInstallCheck = false;
+  nativeInstallCheckInputs = [
     versionCheckHook
   ];
 

pkgs/by-name/me/mergiraf/package.nix

@@ -26,6 +26,10 @@ rustPlatform.buildRustPackage rec {
 
   nativeCheckInputs = [
     git
+  ];
+
+  doInstallCheck = true;
+  nativeInstallCheckInputs = [
     versionCheckHook
   ];
 

pkgs/by-name/ni/nixpkgs-review/package.nix

@@ -70,7 +70,8 @@ python3Packages.buildPythonApplication rec {
     done
   '';
 
-  nativeCheckInputs = [
+  doInstallCheck = true;
+  nativeInstallCheckInputs = [
     versionCheckHook
   ];
   versionCheckProgramArg = [ "--version" ];

pkgs/by-name/nv/nvitop/package.nix

@@ -23,7 +23,8 @@ python3Packages.buildPythonApplication rec {
     nvidia-ml-py
   ];
 
-  nativeCheckInputs = [
+  doInstallCheck = true;
+  nativeInstallCheckInputs = [
     versionCheckHook
   ];
   versionCheckProgramArg = [ "--version" ];

pkgs/by-name/up/upbound/package.nix

@@ -50,6 +50,10 @@ stdenvNoCC.mkDerivation {
     installShellCompletion --bash --name up <(echo complete -C up up)
   '';
 
+  # FIXME: error when running `env -i up`:
+  # "up: error: $HOME is not defined"
+  doInstallCheck = false;
+  versionCheckProgram = "${placeholder "out"}/bin/up";
   versionCheckProgramArg = "version";
 
   nativeInstallCheckInputs = [
@@ -63,10 +67,6 @@ stdenvNoCC.mkDerivation {
     "${version-channel}"
   ];
 
-  passthru.tests = {
-    versionCheck = versionCheckHook;
-  };
-
   meta = {
     description = "CLI for interacting with Upbound Cloud, Upbound Enterprise, and Universal Crossplane (UXP)";
     homepage = "https://upbound.io";