Merge pull request #232178 from fabaff/signify-fix

python311Packages.signify: 0.4.0 -> 0.5.2, mark as broken

pkgs/development/python-modules/mscerts/default.nix

@@ -0,0 +1,36 @@
+{ lib
+, buildPythonPackage
+, fetchFromGitHub
+, pythonOlder
+}:
+
+buildPythonPackage rec {
+  pname = "mscerts";
+  version = "2023.4.26";
+  format = "setuptools";
+
+  disabled = pythonOlder "3.7";
+
+  src = fetchFromGitHub {
+    owner = "ralphje";
+    repo = "mscerts";
+    rev = "refs/tags/${version}";
+    hash = "sha256-7aiSFMZsUtuSqXQ1jJ3OhyBhzAH70ZX5+NqOtrpRmmw=";
+  };
+
+  # extras_require contains signify -> circular dependency
+
+  # Module has no tests
+  doCheck = false;
+
+  pythonImportsCheck = [
+    "mscerts"
+  ];
+
+  meta = with lib; {
+    description = "Makes the Microsoft Trusted Root Program's Certificate Trust Lists available in Python";
+    homepage = "https://github.com/ralphje/mscerts";
+    license = with licenses; [ mpl20 ];
+    maintainers = with maintainers; [ fab ];
+  };
+}

pkgs/development/python-modules/signify/default.nix

@@ -1,31 +1,34 @@
 { lib
-, buildPythonPackage
-, pythonOlder
-, fetchFromGitHub
 , asn1crypto
+, buildPythonPackage
 , certvalidator
+, fetchFromGitHub
+, mscerts
 , oscrypto
 , pyasn1
 , pyasn1-modules
 , pytestCheckHook
+, pythonOlder
 }:
 
 buildPythonPackage rec {
   pname = "signify";
-  version = "0.4.0";
-  disabled = pythonOlder "3.6";
+  version = "0.5.2";
   format = "setuptools";
 
+  disabled = pythonOlder "3.6";
+
   src = fetchFromGitHub {
     owner = "ralphje";
     repo = pname;
-    rev = "v${version}";
-    hash = "sha256-YJc9RIqkEL7dd1ahE4IbxyyZgsZWBDqbXZAvI/nK24M=";
+    rev = "refs/tags/v${version}";
+    hash = "sha256-+UhZF+QYuv8pq/sTu7GDPUrlPNNixFgVZL+L0ulj/ko=";
   };
 
   propagatedBuildInputs = [
     asn1crypto
     certvalidator
+    mscerts
     oscrypto
     pyasn1
     pyasn1-modules
@@ -46,9 +49,12 @@ buildPythonPackage rec {
   ];
 
   meta = with lib; {
-    homepage = "https://github.com/ralphje/signify";
     description = "library that verifies PE Authenticode-signed binaries";
+    homepage = "https://github.com/ralphje/signify";
     license = licenses.mit;
     maintainers = with maintainers; [ baloo ];
+    # No support for pyasn1 > 0.5
+    # https://github.com/ralphje/signify/issues/37
+    broken = true;
   };
 }

pkgs/top-level/python-packages.nix

@@ -6397,6 +6397,8 @@ self: super: with self; {
 
   msal-extensions = callPackage ../development/python-modules/msal-extensions { };
 
+  mscerts = callPackage ../development/python-modules/mscerts { };
+
   msgpack = callPackage ../development/python-modules/msgpack { };
 
   msgpack-numpy = callPackage ../development/python-modules/msgpack-numpy { };