droidcam-obs: 2.0.2 -> 2.3.4; modernize (#382559)

pkgs/applications/video/obs-studio/plugins/droidcam-obs/default.nix

@@ -8,26 +8,19 @@
   libimobiledevice,
   libusbmuxd,
   libplist,
+  pkg-config,
 }:
-
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "droidcam-obs";
-  version = "2.0.2";
+  version = "2.3.4";
 
   src = fetchFromGitHub {
     owner = "dev47apps";
     repo = "droidcam-obs-plugin";
-    rev = version;
-    sha256 = "sha256-YtfWwgBhyQYx6QfrKld7p6qUf8BEV/kkQX4QcdHuaYU=";
+    tag = finalAttrs.version;
+    sha256 = "sha256-KWMLhddK561xA+EjvoG4tXRW4xoLil31JcTTfppblmA=";
   };
 
-  postPatch = ''
-    substituteInPlace ./linux/linux.mk \
-      --replace "-limobiledevice" "-limobiledevice-1.0" \
-      --replace "-I/usr/include/obs" "-I${obs-studio}/include/obs" \
-      --replace "-I/usr/include/ffmpeg" "-I${ffmpeg}/include"
-  '';
-
   preBuild = ''
     mkdir ./build
   '';
@@ -41,11 +34,22 @@ stdenv.mkDerivation rec {
     ffmpeg
   ];
 
+  nativeBuildInputs = [
+    pkg-config
+  ];
+
+  # Flag reference in regard to:
+  # https://github.com/dev47apps/droidcam-obs-plugin/blob/master/linux/linux.mk
   makeFlags = [
     "ALLOW_STATIC=no"
     "JPEG_DIR=${lib.getDev libjpeg}"
     "JPEG_LIB=${lib.getLib libjpeg}/lib"
-    "IMOBILEDEV_DIR=${libimobiledevice}"
+    "IMOBILEDEV_DIR=${lib.getDev libimobiledevice}"
+    "IMOBILEDEV_DIR=${lib.getLib libimobiledevice}"
+    "LIBOBS_INCLUDES=${obs-studio}/include/obs"
+    "FFMPEG_INCLUDES=${lib.getLib ffmpeg}"
+    "LIBUSBMUXD=libusbmuxd-2.0"
+    "LIBIMOBILEDEV=libimobiledevice-1.0"
   ];
 
   installPhase = ''
@@ -61,12 +65,11 @@ stdenv.mkDerivation rec {
 
   doCheck = false;
 
-  meta = with lib; {
+  meta = {
     description = "DroidCam OBS";
     homepage = "https://github.com/dev47apps/droidcam-obs-plugin";
-    license = licenses.gpl2Plus;
-    maintainers = with maintainers; [ ulrikstrid ];
-    platforms = platforms.linux;
-    broken = true;
+    license = lib.licenses.gpl2Plus;
+    maintainers = with lib.maintainers; [ NotAShelf ];
+    platforms = lib.platforms.linux;
   };
-}
+})