librespot: migrate to by-name, modernize derivation (#497265)

pkgs/by-name/li/librespot/package.nix

@@ -9,10 +9,11 @@
   withALSA ? stdenv.hostPlatform.isLinux,
   alsa-lib,
   alsa-plugins,
-  withPortAudio ? false,
+  withPortAudio ? stdenv.hostPlatform.isDarwin,
   portaudio,
-  withPulseAudio ? false,
+  withPulseAudio ? config.pulseaudio or stdenv.hostPlatform.isLinux,
   libpulseaudio,
+  config,
   withRodio ? true,
   withAvahi ? false,
   withMDNS ? true,

pkgs/top-level/all-packages.nix

@@ -9546,12 +9546,6 @@ with pkgs;
     }
   );
 
-  librespot = callPackage ../applications/audio/librespot {
-    withALSA = stdenv.hostPlatform.isLinux;
-    withPulseAudio = config.pulseaudio or stdenv.hostPlatform.isLinux;
-    withPortAudio = stdenv.hostPlatform.isDarwin;
-  };
-
   linssid = libsForQt5.callPackage ../applications/networking/linssid { };
 
   deadd-notification-center = haskell.lib.compose.justStaticExecutables (