terminal-notifier: refactor (#533878)

pkgs/by-name/te/terminal-notifier/package.nix

@@ -1,5 +1,4 @@
 {
-  apple-sdk,
   fetchFromGitHub,
   ibtool,
   lib,
@@ -20,6 +19,10 @@ stdenv.mkDerivation (finalAttrs: {
     hash = "sha256-Hd9cI3R2nQK2deBb5CBYz4DTHAEcO4vzqtA5qZwa1Ao=";
   };
 
+  __structuredAttrs = true;
+
+  strictDeps = true;
+
   nativeBuildInputs = [
     ibtool
     makeBinaryWrapper
@@ -28,15 +31,9 @@ stdenv.mkDerivation (finalAttrs: {
     llvmPackages.lld
   ];
 
-  buildInputs = [
-    apple-sdk
-  ];
-
   xcbuildFlags = [
     "-target"
     "terminal-notifier"
-    "-configuration"
-    "Release"
   ];
 
   # TODO: Clean up on `staging`
@@ -45,12 +42,12 @@ stdenv.mkDerivation (finalAttrs: {
   installPhase = ''
     runHook preInstall
 
-    mkdir -p $out/{Applications,bin}
+    mkdir -p $out/Applications
     cp -r Products/Release/terminal-notifier.app $out/Applications/
+
     makeWrapper \
       $out/Applications/terminal-notifier.app/Contents/MacOS/terminal-notifier \
-      $out/bin/terminal-notifier \
-      --chdir $out/Applications/terminal-notifier.app
+      $out/bin/terminal-notifier
 
     runHook postInstall
   '';