python3Packages.papis: cleanup

pkgs/development/python-modules/papis/default.nix

@@ -45,16 +45,26 @@
   pytest-cov-stub,
   sphinx,
   sphinx-click,
+  writableTmpDirAsHomeHook,
 }:
-buildPythonPackage rec {
+
+buildPythonPackage (finalAttrs: {
   pname = "papis";
   version = "0.14.1";
   pyproject = true;
 
+  patches = [
+    (fetchpatch2 {
+      name = "fix-support-new-click-in-papisrunner.patch";
+      url = "https://github.com/papis/papis/commit/0e3ffff4bd1b62cdf0a9fdc7f54d6a2e2ab90082.patch?full_index=1";
+      hash = "sha256-KUw5U5izTTWqXHzGWLibtqHWAsVxla6SA8x6SJ07/zU=";
+    })
+  ];
+
   src = fetchFromGitHub {
     owner = "papis";
     repo = "papis";
-    tag = "v${version}";
+    tag = "v${finalAttrs.version}";
     hash = "sha256-V4YswLNYwfBYe/Td0PEeDG++ClZoF08yxXjUXuyppPI=";
   };
 
@@ -81,7 +91,7 @@ buildPythonPackage rec {
     requests
     stevedore
   ]
-  ++ lib.optionals withOptDeps optional-dependencies.complete;
+  ++ lib.optionals withOptDeps finalAttrs.passthru.optional-dependencies.complete;
 
   optional-dependencies = {
     complete = [
@@ -102,12 +112,9 @@ buildPythonPackage rec {
     pytest-cov-stub
     sphinx
     sphinx-click
+    writableTmpDirAsHomeHook
   ];
 
-  preCheck = ''
-    export HOME=$(mktemp -d);
-  '';
-
   enabledTestPaths = [
     "papis"
     "tests"
@@ -126,23 +133,15 @@ buildPythonPackage rec {
     "test_git_cli"
   ];
 
-  patches = [
-    (fetchpatch2 {
-      name = "fix-support-new-click-in-papisrunner.patch";
-      url = "https://github.com/papis/papis/commit/0e3ffff4bd1b62cdf0a9fdc7f54d6a2e2ab90082.patch?full_index=1";
-      hash = "sha256-KUw5U5izTTWqXHzGWLibtqHWAsVxla6SA8x6SJ07/zU=";
-    })
-  ];
-
   meta = {
     description = "Powerful command-line document and bibliography manager";
     mainProgram = "papis";
     homepage = "https://papis.readthedocs.io/";
-    changelog = "https://github.com/papis/papis/blob/${src.tag}/CHANGELOG.md";
+    changelog = "https://github.com/papis/papis/blob/${finalAttrs.src.tag}/CHANGELOG.md";
     license = lib.licenses.gpl3Only;
     maintainers = with lib.maintainers; [
       nico202
       teto
     ];
   };
-}
+})