jamin: unbreak on GCC 14, modernize (#394693)

pkgs/by-name/ja/jamin/package.nix

@@ -13,19 +13,20 @@
   perlPackages,
 }:
 
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   version = "0.95.0";
   pname = "jamin";
 
   src = fetchurl {
-    url = "mirror://sourceforge/jamin/jamin-${version}.tar.gz";
-    sha256 = "0g5v74cm0q3p3pzl6xmnp4rqayaymfli7c6z8s78h9rgd24fwbvn";
+    url = "mirror://sourceforge/jamin/jamin-${finalAttrs.version}.tar.gz";
+    hash = "sha256-di/uiGgvJ4iORt+wE6mrXnmFM7m2dkP/HXdgUBk5uzw=";
   };
 
   nativeBuildInputs = [
     pkg-config
     makeWrapper
   ];
+
   buildInputs =
     [
       fftwFloat
@@ -44,17 +45,19 @@ stdenv.mkDerivation rec {
   # gcc-10. Otherwise build fails as:
   #     ld: jamin-preferences.o:/build/jamin-0.95.0/src/hdeq.h:64: multiple definition of
   #       `l_notebook1'; jamin-callbacks.o:/build/jamin-0.95.0/src/hdeq.h:64: first defined here
-  env.NIX_CFLAGS_COMPILE = "-fcommon";
+  # `incompatible-pointer-types` fixes build on GCC 14, otherwise fails with:
+  #   error: passing argument 4 of 'lo_server_thread_add_method' from incompatible pointer type
+  env.NIX_CFLAGS_COMPILE = "-fcommon -Wno-error=incompatible-pointer-types";
 
   postInstall = ''
     wrapProgram $out/bin/jamin --set LADSPA_PATH ${ladspaPlugins}/lib/ladspa
   '';
 
-  meta = with lib; {
+  meta = {
     homepage = "https://jamin.sourceforge.net";
     description = "JACK Audio Mastering interface";
-    license = licenses.gpl2;
-    maintainers = [ maintainers.nico202 ];
-    platforms = platforms.linux;
+    license = lib.licenses.gpl2;
+    maintainers = [ lib.maintainers.nico202 ];
+    platforms = lib.platforms.linux;
   };
-}
+})