workflows/eval: fix compare job not running
The conclusion of the `versions` job propagates from through `eval` to `compare`, which meant the `compare` job was skipped. No rebuild labels, no reviewer requests. Also, we don't want to run eval when `versions` runs, but fails.
This commit is contained in:
4
.github/workflows/eval.yml
vendored
4
.github/workflows/eval.yml
vendored
@@ -57,7 +57,7 @@ jobs:
|
||||
eval:
|
||||
runs-on: ubuntu-24.04-arm
|
||||
needs: versions
|
||||
if: ${{ !cancelled() }}
|
||||
if: ${{ !cancelled() && !failure() }}
|
||||
strategy:
|
||||
fail-fast: false
|
||||
matrix:
|
||||
@@ -197,7 +197,7 @@ jobs:
|
||||
compare:
|
||||
runs-on: ubuntu-24.04-arm
|
||||
needs: [eval]
|
||||
if: needs.eval.outputs.targetRunId
|
||||
if: needs.eval.outputs.targetRunId && !cancelled() && !failure()
|
||||
permissions:
|
||||
statuses: write
|
||||
timeout-minutes: 5
|
||||
|
||||
Reference in New Issue
Block a user