vorta: cleanup (#372512)

pkgs/applications/backup/vorta/default.nix

@@ -1,13 +1,14 @@
 {
   lib,
+  stdenv,
   python3Packages,
   fetchFromGitHub,
   wrapQtAppsHook,
-  borgbackup,
-  qtbase,
   qtwayland,
-  stdenv,
+  borgbackup,
+  versionCheckHook,
   makeFontsConf,
+  qtbase,
 }:
 
 python3Packages.buildPythonApplication rec {
@@ -23,7 +24,6 @@ python3Packages.buildPythonApplication rec {
   };
 
   nativeBuildInputs = [
-    python3Packages.setuptools
     wrapQtAppsHook
   ];
 
@@ -31,18 +31,22 @@ python3Packages.buildPythonApplication rec {
     qtwayland
   ];
 
-  propagatedBuildInputs = with python3Packages; [
-    peewee
-    pyqt6
-    psutil
-    secretstorage
+  build-system = with python3Packages; [
     setuptools
+  ];
+
+  dependencies = with python3Packages; [
+    packaging
+    peewee
     platformdirs
+    psutil
+    pyqt6
+    secretstorage
   ];
 
   postPatch = ''
     substituteInPlace src/vorta/assets/metadata/com.borgbase.Vorta.desktop \
-    --replace com.borgbase.Vorta "com.borgbase.Vorta-symbolic"
+    --replace-fail com.borgbase.Vorta "com.borgbase.Vorta-symbolic"
   '';
 
   postInstall = ''
@@ -61,7 +65,9 @@ python3Packages.buildPythonApplication rec {
     pytest-qt
     pytest-mock
     pytestCheckHook
+    versionCheckHook
   ];
+  versionCheckProgramArg = [ "--version" ];
 
   preCheck =
     let
@@ -89,13 +95,13 @@ python3Packages.buildPythonApplication rec {
       "tests/network_manager/test_darwin.py"
     ];
 
-  meta = with lib; {
+  meta = {
     changelog = "https://github.com/borgbase/vorta/releases/tag/v${version}";
     description = "Desktop Backup Client for Borg";
     homepage = "https://vorta.borgbase.com/";
-    license = licenses.gpl3Only;
-    maintainers = with maintainers; [ ma27 ];
-    platforms = platforms.linux;
+    license = lib.licenses.gpl3Only;
+    maintainers = with lib.maintainers; [ ma27 ];
+    platforms = lib.platforms.linux;
     mainProgram = "vorta";
   };
 }