elvish: refactor

this shouldn't create any rebuilds

pkgs/by-name/el/elvish/package.nix

@@ -5,17 +5,14 @@
   callPackage,
 }:
 
-let
+buildGoModule (finalAttrs: {
   pname = "elvish";
   version = "0.21.0";
-in
-buildGoModule {
-  inherit pname version;
 
   src = fetchFromGitHub {
     owner = "elves";
     repo = "elvish";
-    rev = "v${version}";
+    rev = "v${finalAttrs.version}";
     hash = "sha256-+qkr0ziHWs3MVhBoqAxrwwbsQVvmGHRKrlqiujqBKvs=";
   };
 
@@ -26,7 +23,7 @@ buildGoModule {
   ldflags = [
     "-s"
     "-w"
-    "-X src.elv.sh/pkg/buildinfo.Version==${version}"
+    "-X src.elv.sh/pkg/buildinfo.Version==${finalAttrs.version}"
   ];
 
   strictDeps = true;
@@ -52,4 +49,4 @@ buildGoModule {
     license = lib.licenses.bsd2;
     maintainers = [ ];
   };
-}
+})