Artturin
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
54 lines
1.5 KiB
Nix
54 lines
1.5 KiB
Nix
{
|
|
lib,
|
|
stdenv,
|
|
buildPythonPackage,
|
|
fetchFromGitHub,
|
|
fetchpatch2,
|
|
cython_0,
|
|
zfs,
|
|
}:
|
|
|
|
buildPythonPackage rec {
|
|
pname = "py-libzfs";
|
|
version = "24.04.0";
|
|
format = "setuptools";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "truenas";
|
|
repo = pname;
|
|
rev = "TS-${version}";
|
|
hash = "sha256-Uiu0RNE06++iNWUNcKpbZvreT2D7/EqHlFZJXKe3F4A=";
|
|
};
|
|
|
|
patches = [
|
|
(fetchpatch2 {
|
|
url = "https://github.com/truenas/py-libzfs/commit/b5ffe1f1d6097df6e2f5cc6dd3c968872ec60804.patch";
|
|
hash = "sha256-6r5hQ/o7c4vq4Tfh0l1WbeK3AuPvi+1wzkwkIn1qEes=";
|
|
})
|
|
];
|
|
|
|
build-system = [ cython_0 ];
|
|
buildInputs = [ zfs ];
|
|
|
|
# Passing CFLAGS in configureFlags does not work, see https://github.com/truenas/py-libzfs/issues/107
|
|
postPatch = lib.optionalString stdenv.hostPlatform.isLinux ''
|
|
substituteInPlace configure \
|
|
--replace-fail \
|
|
'CFLAGS="-DCYTHON_FALLTHROUGH"' \
|
|
'CFLAGS="-DCYTHON_FALLTHROUGH -I${zfs.dev}/include/libzfs -I${zfs.dev}/include/libspl"' \
|
|
--replace-fail 'zof=false' 'zof=true'
|
|
'';
|
|
|
|
pythonImportsCheck = [ "libzfs" ];
|
|
|
|
meta = with lib; {
|
|
description = "Python libzfs bindings";
|
|
homepage = "https://github.com/truenas/py-libzfs";
|
|
license = licenses.bsd2;
|
|
maintainers = with maintainers; [ chuangzhu ];
|
|
# The project also supports macOS (OpenZFS on OSX, O3X), FreeBSD and OpenSolaris
|
|
# I don't have a machine to test out, thus only packaged for Linux
|
|
platforms = platforms.linux;
|
|
};
|
|
}
|