Artturin
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
103 lines
3.1 KiB
Nix
103 lines
3.1 KiB
Nix
{
|
|
lib,
|
|
stdenv,
|
|
buildPythonPackage,
|
|
fetchPypi,
|
|
fetchpatch,
|
|
setuptools,
|
|
python,
|
|
pkg-config,
|
|
gdb,
|
|
numpy,
|
|
ncurses,
|
|
}:
|
|
|
|
let
|
|
excludedTests =
|
|
[ "reimport_from_subinterpreter" ]
|
|
# cython's testsuite is not working very well with libc++
|
|
# We are however optimistic about things outside of testsuite still working
|
|
++ lib.optionals (stdenv.cc.isClang or false) [
|
|
"cpdef_extern_func"
|
|
"libcpp_algo"
|
|
]
|
|
# Some tests in the test suite isn't working on aarch64. Disable them for
|
|
# now until upstream finds a workaround.
|
|
# Upstream issue here: https://github.com/cython/cython/issues/2308
|
|
++ lib.optionals stdenv.hostPlatform.isAarch64 [ "numpy_memoryview" ]
|
|
++ lib.optionals stdenv.hostPlatform.isi686 [
|
|
"future_division"
|
|
"overflow_check_longlong"
|
|
];
|
|
in
|
|
buildPythonPackage rec {
|
|
pname = "cython";
|
|
version = "0.29.36";
|
|
pyproject = true;
|
|
|
|
src = fetchPypi {
|
|
pname = "Cython";
|
|
inherit version;
|
|
hash = "sha256-QcDP0tdU44PJ7rle/8mqSrhH0Ml0cHfd18Dctow7wB8=";
|
|
};
|
|
|
|
nativeBuildInputs = [
|
|
pkg-config
|
|
setuptools
|
|
];
|
|
|
|
nativeCheckInputs = [
|
|
gdb
|
|
numpy
|
|
ncurses
|
|
];
|
|
|
|
LC_ALL = "en_US.UTF-8";
|
|
|
|
patches = [
|
|
# backport Cython 3.0 trashcan support (https://github.com/cython/cython/pull/2842) to 0.X series.
|
|
# it does not affect Python code unless the code explicitly uses the feature.
|
|
# trashcan support is needed to avoid stack overflows during object deallocation in sage (https://trac.sagemath.org/ticket/27267)
|
|
./trashcan.patch
|
|
# The above commit introduces custom trashcan macros, as well as
|
|
# compiler changes to use them in Cython-emitted code. The latter
|
|
# change is still useful, but the former has been upstreamed as of
|
|
# Python 3.8, and the patch below makes Cython use the upstream
|
|
# trashcan macros whenever available. This is needed for Python
|
|
# 3.11 support, because the API used in Cython's implementation
|
|
# changed: https://github.com/cython/cython/pull/4475
|
|
(fetchpatch {
|
|
name = "disable-trashcan.patch";
|
|
url = "https://github.com/cython/cython/commit/e337825cdcf5e94d38ba06a0cb0188e99ce0cc92.patch";
|
|
hash = "sha256-q0f63eetKrDpmP5Z4v8EuGxg26heSyp/62OYqhRoSso=";
|
|
})
|
|
];
|
|
|
|
checkPhase = ''
|
|
export HOME="$NIX_BUILD_TOP"
|
|
${python.interpreter} runtests.py -j$NIX_BUILD_CORES \
|
|
--no-code-style \
|
|
${
|
|
lib.optionalString (
|
|
builtins.length excludedTests != 0
|
|
) ''--exclude="(${builtins.concatStringsSep "|" excludedTests})"''
|
|
}
|
|
'';
|
|
|
|
# https://github.com/cython/cython/issues/2785
|
|
# Temporary solution
|
|
doCheck = false;
|
|
# doCheck = !stdenv.hostPlatform.isDarwin;
|
|
|
|
# force regeneration of generated code in source distributions
|
|
# https://github.com/cython/cython/issues/5089
|
|
setupHook = ./setup-hook.sh;
|
|
|
|
meta = {
|
|
changelog = "https://github.com/cython/cython/blob/${version}/CHANGES.rst";
|
|
description = "Optimising static compiler for both the Python programming language and the extended Cython programming language";
|
|
homepage = "https://cython.org";
|
|
license = lib.licenses.asl20;
|
|
};
|
|
}
|