Peder Bergebakken Sundt
8bffdd4ccf
This treewide conditions execution of the built applications for the purpose of generating shell completions behind `stdenv.buildPlatform.canExecute stdenv.hostPlatform`, which helps cross. This is a common issue I spot during review, let's prevent copy-paste errors by fixing it treewide.
Candidates were located with:
```shell
rg 'installShellCompletion' -l -tnix | xargs grep -F 'stdenv.buildPlatform.canExecute stdenv.hostPlatform' -L
```
Then I migrated the obvious cases which would not require a rebuild, as a means of testing.
This diff was not scripted. Should be zero rebuilds.
<details>
<summary>
Alternatives
</summary>
Alternatively I could have use this pattern:
```nix
postInstall = lib.optionalString (stdenv.hostPlatform.emulatorAvailable buildPackages) (
let
emulator = stdenv.hostPlatform.emulator buildPackages;
in
''
installShellCompletion --cmd foobar \
--bash <(${emulator} $out/bin/foobar completion bash) \
--fish <(${emulator} $out/bin/foobar completion fish) \
--zsh <(${emulator} $out/bin/foobar completion zsh)
''
);
```
but that would cause rebuilds and will also require testing.
---
An other alternative is to use the binary from the corresponding package in `buildPackages`.
This however would also cause rebuilds and will also require testing.
</details>
97 lines
2.2 KiB
Nix
97 lines
2.2 KiB
Nix
{
|
|
stdenv,
|
|
buildPythonApplication,
|
|
colorclass,
|
|
fetchPypi,
|
|
fetchurl,
|
|
installShellFiles,
|
|
lib,
|
|
linode-metadata,
|
|
openapi3,
|
|
packaging,
|
|
pyyaml,
|
|
requests,
|
|
rich,
|
|
setuptools,
|
|
terminaltables,
|
|
}:
|
|
|
|
let
|
|
hash = "sha256-QQxadKVEIh1PvD8FdYgJ/U1iyWdy6FvO+LUELQ70KKw=";
|
|
# specVersion taken from: https://www.linode.com/docs/api/openapi.yaml at `info.version`.
|
|
specVersion = "4.176.0";
|
|
specHash = "sha256-P1E8Ga5ckrsw/CX0kxFef5fe8/p/pDCLuleX9wR5l48=";
|
|
spec = fetchurl {
|
|
url = "https://raw.githubusercontent.com/linode/linode-api-docs/v${specVersion}/openapi.yaml";
|
|
hash = specHash;
|
|
};
|
|
|
|
in
|
|
|
|
buildPythonApplication rec {
|
|
pname = "linode-cli";
|
|
version = "5.56.2";
|
|
pyproject = true;
|
|
|
|
src = fetchPypi {
|
|
pname = "linode_cli";
|
|
inherit version;
|
|
hash = hash;
|
|
};
|
|
|
|
patches = [ ./remove-update-check.patch ];
|
|
|
|
# remove need for git history
|
|
prePatch = ''
|
|
substituteInPlace setup.py \
|
|
--replace "version = get_version()" "version='${version}',"
|
|
'';
|
|
|
|
postConfigure = ''
|
|
python3 -m linodecli bake ${spec} --skip-config
|
|
cp data-3 linodecli/
|
|
echo "${version}" > baked_version
|
|
'';
|
|
|
|
nativeBuildInputs = [ installShellFiles ];
|
|
|
|
propagatedBuildInputs = [
|
|
colorclass
|
|
linode-metadata
|
|
pyyaml
|
|
requests
|
|
setuptools
|
|
terminaltables
|
|
rich
|
|
openapi3
|
|
packaging
|
|
];
|
|
|
|
doInstallCheck = true;
|
|
installCheckPhase = ''
|
|
$out/bin/linode-cli --skip-config --version | grep ${version} > /dev/null
|
|
'';
|
|
|
|
postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) ''
|
|
for shell in bash fish; do
|
|
installShellCompletion --cmd linode-cli \
|
|
--$shell <($out/bin/linode-cli --skip-config completion $shell)
|
|
done
|
|
'';
|
|
|
|
passthru.updateScript = ./update.sh;
|
|
|
|
meta = {
|
|
description = "Linode Command Line Interface";
|
|
changelog = "https://github.com/linode/linode-cli/releases/tag/v${version}";
|
|
downloadPage = "https://pypi.org/project/linode-cli";
|
|
homepage = "https://github.com/linode/linode-cli";
|
|
license = lib.licenses.bsd3;
|
|
maintainers = with lib.maintainers; [
|
|
ryantm
|
|
techknowlogick
|
|
];
|
|
mainProgram = "linode-cli";
|
|
};
|
|
}
|