c2b898da76
Passing `-l$NIX_BUILD_CORES` improperly limits the overall system load. For a build machine which is configured to run `$B` builds where each build gets `total cores / B` cores (`$C`), passing `-l $C` to make will improperly limit the load to `$C` instead of `$B * $C`. This effect becomes quite pronounced on machines with 80 cores, with 40 simultaneous builds and a cores limit of 2. On a machine with this configuration, Nix will run 40 builds and make will limit the overall system load to approximately 2. A build machine with this many cores can happily run with a load approaching 80. A non-solution is to oversubscribe the machine, by picking a larger `$C`. However, there is no way to divide the number of cores in a way which fairly subdivides the available cores when `$B` is greater than 1. There has been exploration of passing a jobserver in to the sandbox, or sharing a jobserver between all the builds. This is one option, but relatively complicated and only supports make. Lots of other software uses its own implementation of `-j` and doesn't support either `-l` or the Make jobserver. For the case of an interactive user machine, the user should limit overall system load using `$B`, `$C`, and optionally systemd's cpu/network/io limiting features. Making this change should significantly improve the utilization of our build farm, and improve the throughput of Hydra.
85 lines
2.1 KiB
Nix
85 lines
2.1 KiB
Nix
{ stdenv
|
|
, lib
|
|
, buildPythonPackage
|
|
, fetchFromGitHub
|
|
, cmake
|
|
, boost
|
|
, eigen
|
|
, python
|
|
, catch
|
|
, numpy
|
|
, pytestCheckHook
|
|
}:
|
|
|
|
buildPythonPackage rec {
|
|
pname = "pybind11";
|
|
version = "2.10.0";
|
|
|
|
src = fetchFromGitHub {
|
|
owner = "pybind";
|
|
repo = pname;
|
|
rev = "v${version}";
|
|
hash = "sha256-/X8DZPFsNrKGbhjZ1GFOj17/NU6p4R+saCW3pLKVNeA=";
|
|
};
|
|
|
|
postPatch = ''
|
|
sed -i "/^timeout/d" pyproject.toml
|
|
'';
|
|
|
|
nativeBuildInputs = [ cmake ];
|
|
|
|
dontUseCmakeBuildDir = true;
|
|
|
|
cmakeFlags = [
|
|
"-DBoost_INCLUDE_DIR=${lib.getDev boost}/include"
|
|
"-DEIGEN3_INCLUDE_DIR=${lib.getDev eigen}/include/eigen3"
|
|
"-DBUILD_TESTING=on"
|
|
"-DPYTHON_EXECUTABLE:FILEPATH=${python.pythonForBuild.interpreter}"
|
|
] ++ lib.optionals (python.isPy3k && !stdenv.cc.isClang) [
|
|
"-DPYBIND11_CXX_STANDARD=-std=c++17"
|
|
];
|
|
|
|
postBuild = ''
|
|
# build tests
|
|
make -j $NIX_BUILD_CORES
|
|
'';
|
|
|
|
postInstall = ''
|
|
make install
|
|
# Symlink the CMake-installed headers to the location expected by setuptools
|
|
mkdir -p $out/include/${python.libPrefix}
|
|
ln -sf $out/include/pybind11 $out/include/${python.libPrefix}/pybind11
|
|
'';
|
|
|
|
checkInputs = [
|
|
catch
|
|
numpy
|
|
pytestCheckHook
|
|
];
|
|
|
|
disabledTestPaths = [
|
|
# require dependencies not available in nixpkgs
|
|
"tests/test_embed/test_trampoline.py"
|
|
"tests/test_embed/test_interpreter.py"
|
|
# numpy changed __repr__ output of numpy dtypes
|
|
"tests/test_numpy_dtypes.py"
|
|
# no need to test internal packaging
|
|
"tests/extra_python_package/test_files.py"
|
|
# tests that try to parse setuptools stdout
|
|
"tests/extra_setuptools/test_setuphelper.py"
|
|
];
|
|
|
|
meta = with lib; {
|
|
homepage = "https://github.com/pybind/pybind11";
|
|
changelog = "https://github.com/pybind/pybind11/blob/${src.rev}/docs/changelog.rst";
|
|
description = "Seamless operability between C++11 and Python";
|
|
longDescription = ''
|
|
Pybind11 is a lightweight header-only library that exposes
|
|
C++ types in Python and vice versa, mainly to create Python
|
|
bindings of existing C++ code.
|
|
'';
|
|
license = licenses.bsd3;
|
|
maintainers = with maintainers; [ yuriaisaka dotlambda ];
|
|
};
|
|
}
|