Artturin
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
55 lines
1.3 KiB
Nix
55 lines
1.3 KiB
Nix
{
|
|
lib,
|
|
buildPythonPackage,
|
|
fetchPypi,
|
|
pytest,
|
|
requests,
|
|
process-tests,
|
|
}:
|
|
|
|
buildPythonPackage rec {
|
|
pname = "manhole";
|
|
version = "1.8.1";
|
|
format = "setuptools";
|
|
|
|
src = fetchPypi {
|
|
inherit pname version;
|
|
sha256 = "sha256-Nmj9r4OzPJQ9tOdQ4MVU4xwg9jM4SWiV3U1kEGgNnEs=";
|
|
};
|
|
|
|
# test_help expects architecture-dependent Linux signal numbers.
|
|
#
|
|
# {test_locals,test_socket_path} fail to remove /tmp/manhole-socket
|
|
# on the x86_64-darwin builder.
|
|
#
|
|
# TODO: change this back to `doCheck = stdenv.hostPlatform.isLinux` after
|
|
# https://github.com/ionelmc/python-manhole/issues/54 is fixed
|
|
doCheck = false;
|
|
|
|
nativeCheckInputs = [
|
|
pytest
|
|
requests
|
|
process-tests
|
|
];
|
|
checkPhase = ''
|
|
# Based on its tox.ini
|
|
export PYTHONUNBUFFERED=yes
|
|
export PYTHONPATH=.:tests:$PYTHONPATH
|
|
|
|
# The tests use manhole-cli
|
|
export PATH="$PATH:$out/bin"
|
|
|
|
# test_uwsgi fails with:
|
|
# http.client.RemoteDisconnected: Remote end closed connection without response
|
|
py.test -vv -k "not test_uwsgi"
|
|
'';
|
|
|
|
meta = with lib; {
|
|
homepage = "https://github.com/ionelmc/python-manhole";
|
|
description = "Debugging manhole for Python applications";
|
|
mainProgram = "manhole-cli";
|
|
license = licenses.bsd2;
|
|
maintainers = with maintainers; [ ivan ];
|
|
};
|
|
}
|