Artturin
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
78 lines
2.5 KiB
Nix
78 lines
2.5 KiB
Nix
{ lib, stdenv, fetchurl, fetchpatch, python, pkg-config, gtk2, pygobject2, pycairo, pango
|
|
, buildPythonPackage, isPy3k }:
|
|
|
|
buildPythonPackage rec {
|
|
pname = "pygtk";
|
|
outputs = [ "out" "dev" ];
|
|
version = "2.24.0";
|
|
format = "other";
|
|
|
|
disabled = isPy3k;
|
|
|
|
src = fetchurl {
|
|
url = "mirror://gnome/sources/${pname}/${lib.versions.majorMinor version}/${pname}-${version}.tar.bz2";
|
|
sha256 = "04k942gn8vl95kwf0qskkv6npclfm31d78ljkrkgyqxxcni1w76d";
|
|
};
|
|
|
|
patches = [
|
|
# https://bugzilla.gnome.org/show_bug.cgi?id=660216 - fixes some memory leaks
|
|
(fetchpatch {
|
|
url = "https://gitlab.gnome.org/Archive/pygtk/commit/eca72baa5616fbe4dbebea43c7e5940847dc5ab8.diff";
|
|
sha256 = "031px4w5cshcx1sns430sdbr2i007b9zyb2carb3z65nzr77dpdd";
|
|
})
|
|
(fetchpatch {
|
|
url = "https://gitlab.gnome.org/Archive/pygtk/commit/4aaa48eb80c6802aec6d03e5695d2a0ff20e0fc2.patch";
|
|
sha256 = "0z8cg7nr3qki8gg8alasdzzyxcihfjlxn518glq5ajglk3q5pzsn";
|
|
})
|
|
];
|
|
|
|
nativeBuildInputs = [ pkg-config ];
|
|
buildInputs = [
|
|
pango
|
|
];
|
|
|
|
propagatedBuildInputs = [ gtk2 pygobject2 pycairo ];
|
|
|
|
configurePhase = "configurePhase";
|
|
|
|
buildPhase = "buildPhase";
|
|
|
|
env.NIX_CFLAGS_COMPILE = lib.optionalString stdenv.hostPlatform.isDarwin "-ObjC"
|
|
+ lib.optionalString (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64) " -lpython2.7";
|
|
|
|
installPhase = "installPhase";
|
|
|
|
checkPhase =
|
|
''
|
|
sed -i -e "s/glade = importModule('gtk.glade', buildDir)//" \
|
|
tests/common.py
|
|
sed -i -e "s/, glade$//" \
|
|
-e "s/.*testGlade.*//" \
|
|
-e "s/.*(glade.*//" \
|
|
tests/test_api.py
|
|
'' + ''
|
|
sed -i -e "s/sys.path.insert(0, os.path.join(buildDir, 'gtk'))//" \
|
|
-e "s/sys.path.insert(0, buildDir)//" \
|
|
tests/common.py
|
|
make check
|
|
'';
|
|
# XXX: TypeError: Unsupported type: <class 'gtk._gtk.WindowType'>
|
|
# The check phase was not executed in the previous
|
|
# non-buildPythonPackage setup - not sure why not.
|
|
doCheck = false;
|
|
|
|
postInstall = ''
|
|
rm $out/bin/pygtk-codegen-2.0
|
|
ln -s ${pygobject2}/bin/pygobject-codegen-2.0 $out/bin/pygtk-codegen-2.0
|
|
ln -s ${pygobject2}/${python.sitePackages}/pygobject-${pygobject2.version}.pth \
|
|
$out/${python.sitePackages}/${pname}-${version}.pth
|
|
'';
|
|
|
|
meta = with lib; {
|
|
description = "GTK 2 Python bindings";
|
|
homepage = "https://gitlab.gnome.org/Archive/pygtk";
|
|
platforms = platforms.all;
|
|
license = with licenses; [ lgpl21Plus ];
|
|
};
|
|
}
|