Because of the branches filter, the job would **not** re-run when only
the base-branch was changed, thus leaving the contributor with a failed
check.
With this change, the job should be triggered and then skipped in this
case, so the check in the list should be replaced with a skip.
Note, this also means that this step will show up in every PR as
skipped, even when it was never failed before.
Somehow, the was_successful output didn't work correctly. It's hard to
imagine that the created_pull_numbers output fails the same way,
because... when the backport action fails there **are no pull request
numbers**.
Introduced in #402332, but broken on all ends:
- pull_request needs to be event.pull_request
- pull_request.head is an object, not a string
- github.ref_protected is about the target branch, because this runs as
a pull_request_target event
Thus, we need to list the branches manually.
This allows filtering for PRs with a backport label, but without the
"has: port to stable" label to find those which need to be manually
acted on.
Resolves#325359
The backport job was previously triggered on any label activity, i.e.
when the backport label was already set and a new label added, the
backport would have been triggered again.
That's because github.event_name is actually "pull_request_target" in
this case, not "closed" or "labeled" (the event's types). Thus, this
part of the condition was always true.
This also means that the second part, the startsWith, was never
evaluated. It had its arguments flipped and would have always been
false.
This was introduced in #126825, but has never really worked as intended.
Resolves#199556
This adds some labels related to the higher level workflows of
developing nixpkgs:
- "4.workflow: backport" can be used to filter everything targeting the
stable branches, both release-XX.YY or staging-XX.YY.
- "4.workflow: package set updates" can be used to filter the
haskell/python package set PRs. Can be combined with "6.topic: haskell"
or "6.topic: python".
- "4.workflow: staging" can be used to filter for all staging-next PRs,
both to master and release branches.
Browser updates should always be backported for security reasons, so
let's make our life a bit easier by adding the backport label for
r-ryantm's PRs automatically.
The Package Request form no longer exists, so it makes no sense to mention it. We used to direct update requests to forks there, instead, users can now mention forks in the Additional Context section added in this commit.
Signed-off-by: Fernando Rodrigues <alpha@sigmasquadron.net>
Changes the Nix format checking workflow to now strictly enforce
formatting of all Nix files using the treefmt setup introduced
in the pre-previous commit.
This is in [accordance with the approved RFC 166](https://github.com/NixOS/rfcs/blob/master/rfcs/0166-nix-formatting.md#reformat-nixpkgs).
Note that the "skip treewide" thing is no longer necessary, already
before, because there's nothing that would fail for treewide changes.
Previously the problem was that the GitHub API would be bombarded.
