The latest version of the file that gets pulled has a prerelease version
of solidity 0.8.31, which makes the compilation of `svm-rs-builds` fail
with a duplicate constant definition error. This commit fixes the script
by filtering out the prerelease versions with jq.
- Remove the internal conditioning on the result of `valid`, we can know
exactly when which value is produced
- Faster success path for checkMeta, also avoiding an environment
- Inline handlers
Reapplying 660cecdc16
after reversal in 0b90ed8913
- Boolean operator short-circuit optimisation
- Eta-reduction and make some allow/blocklist-dependend functions more cachable
- Inline functions that are only used once
- Make getEnv cached
Reapplying f7486d2a63
after reversal in 0b90ed8913
- Avoid some attribute set accesses
- Make a variable more local, avoiding a thunk
- Avoid always checking config.checkMeta for every attribute
Reapplying ab0c4c104c
after reversal in 0b90ed8913
- Makes the code more clean and obvious
- Allows remediations to depend on values computed during the check
(useful for https://github.com/NixOS/nixpkgs/pull/338267)
Reapplying 42cfcdf4e7
after reversal in 0b90ed8913
Compared to the original commit, this includes the fix for the problem
that required the revert.
When we pass the `TargetFrameworks` in `dotnetFlags` we got some weird
unexpected behavior, the `generateAssemblyInfo.sh` wasn't executed,
AssemblyInfo is not generated and we hit
[this](https://github.com/renode/renode/blob/master/src/Renode/Program.cs#L161)
exception.
But this `generateAssemblyInfo` script only replaces version and commit
rev in a `.template` file to generate a `.cs` file. We can do this step
via Nix and everything works correctly.
Signed-off-by: Samuel Silva <samuel@ossystems.com.br>
