A comment in src/targets/gpu/kernels/include/migraphx/kernels/bit.hpp
contains a Unicode MINUS SIGN instead of ASCII hyphen:
// popcount(~(x | −x))
When EMBED_USE=CArrays, the cmake Embed.cmake mechanism reads source
files as hex and generates char[] arrays. The UTF-8 encoding of U+2212
(0xe2 0x88 0x92) causes a compile error:
constant expression evaluates to 226 which cannot be narrowed
to type 'char' [-Wc++11-narrowing]
Applies:
- fix(rdc): Fix CXXFLAGS clobbering and incompatibility with non-x64 architecture ROCm/rocm-systems#2423
- fix(rdc): use pkg-config to find libcap ROCm/rocm-systems#2424
The build was failing on systems using clang due to an integer conversion warning being treated as an error.
Followed a similar fix in the hombrew formula to unbreak.
Fixes: #286775
Currently ReadWritePaths is only sufficiently specificed for
acme-order-renew-${domain}.service, and not acme-${domain}.service. This
results in service failure if specifying the webroot outside of
/var/lib/acme, for example /var/www/challenges:
acme-example.com-start[1379]: + mkdir -p /var/www/challenges//.well-known/acme-challenge
acme-example.com-start[1382]: mkdir: cannot create directory ‘/var/www/challenges//.well-known’: Read-only file system
systemd[1]: acme-example.com.service: Main process exited, code=exited, status=1/FAILURE
Fix it by adding the webroots to ReadWritePaths in the common
serviceConfig, where it can affect both acme-order-renew-${domain}.service
AND acme-${domain}.service.
Avoid adding subdirs of existing ReadWritePaths entries, because
otherwise systemd will fail to set up the services, for example:
acme-zeroconf.example.test.service: Failed to set up mount namespacing: /run/acme: No such file or directory
(Confusingly, the path shown in the error message isn't necessarily
related to the problematic path.)
Luna Nova