nodejs.nix currently creates configureScript with writeScript. This produces an
executable text file without a shebang, which configurePhase then runs as
$configureScript.
The wrapper only invokes configure.py through Python, so call configure.py
through python.interpreter directly instead. This avoids the shebang-less
wrapper path and stops relying on python.executable being resolved through
PATH.
Not-cherry-picked-because: icu will be advanced globally on the unstable branch by https://github.com/NixOS/nixpkgs/pull/520553
Signed-off-by: Marcin Serwin <marcin@serwin.dev>
(cherry picked from commit 4b965d7e22e3f82c9e9c77dd51bdd70679f0a904)
Based on upstream's support list, only supported BE platforms are s390x-linux and ppc64-aix.
We don't have support for AIX in lib, and I don't know what the exact triplet for that would be, so it's not included here.
This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
http-parser has been unmaintained for a long time, and is marked to only
be enabled with nodejs versions older than 11.4, which was released back
in 2018, and the 11.x series was made EOL around that same time.
Therefore, there is absolutely no need to keep this around.
The following tests fail on Darwin with the sandbox enabled [1]:
not ok 2612 parallel/test-runner-output
not ok 3053 parallel/test-tls-get-ca-certificates-system
not ok 3054 parallel/test-tls-get-ca-certificates-system-without-flag
not ok 3363 parallel/test-watch-file-shared-dependency
not ok 4057 parallel/test-runner-complex-dependencies
not ok 4058 parallel/test-runner-global-setup-watch-mode
not ok 4228 sequential/test-watch-mode-watch-flags
Node.js uses Security.framework to read the system CA certificates from
the system keychain on Darwin. Fix the tls-get-ca-certificates-system
tests by adding the files and Mach services used by Security.framework
to the sandbox profile. Also allow the FSEvents Mach service as the
runner and watch tests use FSEvents on Darwin.
[1]: https://gist.github.com/al3xtjames/0eb3c30d37c1ebab99968c62ee544300
