From ff9e4bce32b35ab6fc61e8ad64e5b91c0624c5b4 Mon Sep 17 00:00:00 2001 From: Thomas Miedema Date: Mon, 17 Mar 2025 08:16:53 +0100 Subject: [PATCH] haskell: fix shellFor test In #296645, envFunc (and thus shellFor) was changed from `mkDerivation {phases=[..]}` to `runCommand ..`. So since then, the derivation of shellFor contains a `buildCommand` ("echo $nativeBuildInputs $buildInputs > $out"), and as a result the custom phases defined in shellFor's test were ignored. --- pkgs/test/haskell/shellFor/default.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/test/haskell/shellFor/default.nix b/pkgs/test/haskell/shellFor/default.nix index 3e0f3ed74934..87671f4bc798 100644 --- a/pkgs/test/haskell/shellFor/default.nix +++ b/pkgs/test/haskell/shellFor/default.nix @@ -68,4 +68,8 @@ maintainers = allMaintainers; inherit (cabal-install.meta) platforms; }; + # `shellFor` adds a `buildCommand` (via `envFunc -> runCommandCC`), which + # overrides custom phases. To ensure this test's phases run, we remove + # that `buildCommand` from the derivation. + buildCommand = null; })