From 6ca8d9b06fc825a062a4630ab4ebfdecc6328f65 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 18:35:51 +0200 Subject: [PATCH 01/23] electron{,-bin}: add passthru.dist attribute --- .../development/tools/electron/binary/generic.nix | 15 ++++++++++----- pkgs/development/tools/electron/common.nix | 7 ++++++- pkgs/development/tools/electron/wrapper.nix | 2 +- 3 files changed, 17 insertions(+), 7 deletions(-) diff --git a/pkgs/development/tools/electron/binary/generic.nix b/pkgs/development/tools/electron/binary/generic.nix index 6b0d3d12e5e3..60255d21bcb1 100644 --- a/pkgs/development/tools/electron/binary/generic.nix +++ b/pkgs/development/tools/electron/binary/generic.nix @@ -107,7 +107,7 @@ let ++ lib.optionals (lib.versionAtLeast version "17.0.0") [ libGL vulkan-loader ] ); - linux = { + linux = finalAttrs: { buildInputs = [ glib gtk3 ]; nativeBuildInputs = [ @@ -142,9 +142,11 @@ let rm "$out/libexec/electron/libvulkan.so.1" ln -s -t "$out/libexec/electron" "${lib.getLib vulkan-loader}/lib/libvulkan.so.1" ''; + + passthru.dist = finalAttrs.finalPackage + "/libexec/electron"; }; - darwin = { + darwin = finalAttrs: { nativeBuildInputs = [ makeWrapper unzip @@ -157,9 +159,12 @@ let mkdir -p $out/bin makeWrapper $out/Applications/Electron.app/Contents/MacOS/Electron $out/bin/electron ''; + + passthru.dist = finalAttrs.finalPackage + "/Applications"; }; in - stdenv.mkDerivation ( - (common stdenv.hostPlatform) // - (if stdenv.isDarwin then darwin else linux) + stdenv.mkDerivation (finalAttrs: + lib.recursiveUpdate + (common stdenv.hostPlatform) + ((if stdenv.isDarwin then darwin else linux) finalAttrs) ) diff --git a/pkgs/development/tools/electron/common.nix b/pkgs/development/tools/electron/common.nix index 1e863827710d..e98e93a0a17d 100644 --- a/pkgs/development/tools/electron/common.nix +++ b/pkgs/development/tools/electron/common.nix @@ -27,7 +27,7 @@ let fetchedDeps = lib.mapAttrs (name: fetchdep) info.deps; -in (chromium.override { upstream-info = info.chromium; }).mkDerivation (base: { +in ((chromium.override { upstream-info = info.chromium; }).mkDerivation (base: { packageName = "electron"; inherit (info) version; buildTargets = [ "electron:electron_dist_zip" ]; @@ -244,4 +244,9 @@ in (chromium.override { upstream-info = info.chromium; }).mkDerivation (base: { hydraPlatforms = lib.optionals (!(hasInfix "alpha" info.version) && !(hasInfix "beta" info.version)) ["aarch64-linux" "x86_64-linux"]; timeout = 172800; # 48 hours (increased from the Hydra default of 10h) }; +})).overrideAttrs (finalAttrs: prevAttrs: { + # this was the only way I could get the package to properly reference itself + passthru = prevAttrs.passthru // { + dist = finalAttrs.finalPackage + "/libexec/electron"; + }; }) diff --git a/pkgs/development/tools/electron/wrapper.nix b/pkgs/development/tools/electron/wrapper.nix index c912c059e255..8c48e8f695fc 100644 --- a/pkgs/development/tools/electron/wrapper.nix +++ b/pkgs/development/tools/electron/wrapper.nix @@ -31,7 +31,7 @@ stdenv.mkDerivation { passthru = { unwrapped = electron-unwrapped; - inherit (electron-unwrapped) headers; + inherit (electron-unwrapped) headers dist; }; inherit (electron-unwrapped) meta; } From 62f87890bca126809258a00bbaaa08371e8f606e Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Mon, 12 Aug 2024 22:21:00 +0200 Subject: [PATCH 02/23] armcord: use electron.dist --- .../networking/instant-messengers/armcord/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/instant-messengers/armcord/default.nix b/pkgs/applications/networking/instant-messengers/armcord/default.nix index 469557d67dd3..4d07c850986e 100644 --- a/pkgs/applications/networking/instant-messengers/armcord/default.nix +++ b/pkgs/applications/networking/instant-messengers/armcord/default.nix @@ -35,7 +35,7 @@ stdenv.mkDerivation rec { npm exec electron-builder -- \ --dir \ - -c.electronDist="${electron_30}/libexec/electron" \ + -c.electronDist="${electron_30.dist}" \ -c.electronVersion="${electron_30.version}" runHook postBuild From a1a370759963ef1193d88cc1c95224a61bdc4347 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:15:09 +0200 Subject: [PATCH 03/23] bitwarden-desktop: use electron.dist --- pkgs/by-name/bi/bitwarden-desktop/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/bi/bitwarden-desktop/package.nix b/pkgs/by-name/bi/bitwarden-desktop/package.nix index 2ce70a8372cf..c2ce56ae2331 100644 --- a/pkgs/by-name/bi/bitwarden-desktop/package.nix +++ b/pkgs/by-name/bi/bitwarden-desktop/package.nix @@ -120,7 +120,7 @@ in buildNpmPackage rec { npm exec electron-builder -- \ --dir \ - -c.electronDist=${electron}/libexec/electron \ + -c.electronDist=${electron.dist} \ -c.electronVersion=${electron.version} popd From 87d85025f8063ee99eff70ef8889e5b6150dc901 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:17:29 +0200 Subject: [PATCH 04/23] bitwarden-directory-connector: use electron.dist --- pkgs/tools/security/bitwarden-directory-connector/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/tools/security/bitwarden-directory-connector/default.nix b/pkgs/tools/security/bitwarden-directory-connector/default.nix index 1774598ec44a..7546f4262697 100644 --- a/pkgs/tools/security/bitwarden-directory-connector/default.nix +++ b/pkgs/tools/security/bitwarden-directory-connector/default.nix @@ -66,7 +66,7 @@ in { npm exec electron-builder -- \ --dir \ - -c.electronDist=${electron}/libexec/electron \ + -c.electronDist=${electron.dist} \ -c.electronVersion=${electron.version} \ -c.npmRebuild=false From 4de880ad6d279f53a9ebae5ea6dc673dbbef7fdf Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 21:11:27 +0200 Subject: [PATCH 05/23] blockbench: use electron.dist --- pkgs/by-name/bl/blockbench/package.nix | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkgs/by-name/bl/blockbench/package.nix b/pkgs/by-name/bl/blockbench/package.nix index 2f72c033f10e..a8458255c714 100644 --- a/pkgs/by-name/bl/blockbench/package.nix +++ b/pkgs/by-name/bl/blockbench/package.nix @@ -10,9 +10,6 @@ electron, }: -let - electronDist = "${electron}/${if stdenv.isDarwin then "Applications" else "libexec/electron"}"; -in buildNpmPackage rec { pname = "blockbench"; version = "4.10.4"; @@ -45,7 +42,7 @@ buildNpmPackage rec { postBuild = '' # electronDist needs to be modifiable on Darwin - cp -r ${electronDist} electron-dist + cp -r ${electron.dist} electron-dist chmod -R u+w electron-dist npm exec electron-builder -- \ From cade99381b70b408f593a84402ce8b8380251ef7 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Mon, 12 Aug 2024 22:12:07 +0200 Subject: [PATCH 06/23] bruno: use electron.dist --- pkgs/by-name/br/bruno/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/br/bruno/package.nix b/pkgs/by-name/br/bruno/package.nix index 9c2dafc1aeae..e49ed0b4d2c7 100644 --- a/pkgs/by-name/br/bruno/package.nix +++ b/pkgs/by-name/br/bruno/package.nix @@ -103,7 +103,7 @@ buildNpmPackage' rec { ${ if stdenv.isDarwin then '' - cp -r ${electron}/Applications/Electron.app ./ + cp -r ${electron.dist}/Electron.app ./ find ./Electron.app -name 'Info.plist' | xargs -d '\n' chmod +rw substituteInPlace electron-builder-config.js \ @@ -121,7 +121,7 @@ buildNpmPackage' rec { '' npm exec electron-builder -- \ --dir \ - -c.electronDist=${electron}/libexec/electron \ + -c.electronDist=${electron.dist} \ -c.electronVersion=${electron.version} \ -c.npmRebuild=false '' From 3ea2d8d17046ea4720763e2435518c5a3b910db7 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 27 Aug 2024 21:34:05 +0200 Subject: [PATCH 07/23] caprine: use electron.dist --- pkgs/by-name/ca/caprine/package.nix | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkgs/by-name/ca/caprine/package.nix b/pkgs/by-name/ca/caprine/package.nix index 214b304ff577..e6e2106b3809 100644 --- a/pkgs/by-name/ca/caprine/package.nix +++ b/pkgs/by-name/ca/caprine/package.nix @@ -8,9 +8,6 @@ electron, }: -let - electronDist = electron + (if stdenv.isDarwin then "/Applications" else "/libexec/electron"); -in buildNpmPackage rec { pname = "caprine"; version = "2.60.1"; @@ -29,7 +26,7 @@ buildNpmPackage rec { nativeBuildInputs = [ copyDesktopItems ]; postBuild = '' - cp -r ${electronDist} electron-dist + cp -r ${electron.dist} electron-dist chmod -R u+w electron-dist npm exec electron-builder -- \ From 4fa5aad84255195215523bac8176fab06e361737 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:12:53 +0200 Subject: [PATCH 08/23] drawio: use electron.dist --- pkgs/applications/graphics/drawio/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/graphics/drawio/default.nix b/pkgs/applications/graphics/drawio/default.nix index 4ad76a3d98d9..1442d794e374 100644 --- a/pkgs/applications/graphics/drawio/default.nix +++ b/pkgs/applications/graphics/drawio/default.nix @@ -63,14 +63,14 @@ stdenv.mkDerivation rec { runHook preBuild '' + lib.optionalString stdenv.isDarwin '' - cp -R ${electron}/Applications/Electron.app Electron.app + cp -R ${electron.dist}/Electron.app Electron.app chmod -R u+w Electron.app export CSC_IDENTITY_AUTO_DISCOVERY=false sed -i "/afterSign/d" electron-builder-linux-mac.json '' + '' yarn --offline run electron-builder --dir \ - ${if stdenv.isDarwin then "--config electron-builder-linux-mac.json" else ""} \ - -c.electronDist=${if stdenv.isDarwin then "." else "${electron}/libexec/electron"} \ + ${lib.optionalString stdenv.isDarwin "--config electron-builder-linux-mac.json"} \ + -c.electronDist=${if stdenv.isDarwin then "." else electron.dist} \ -c.electronVersion=${electron.version} runHook postBuild From 939d0a5a6dab4e4f2d6553fb11ab7569f98590cb Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:16:49 +0200 Subject: [PATCH 09/23] electron-fiddle: use electron.dist --- pkgs/development/tools/electron-fiddle/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/tools/electron-fiddle/default.nix b/pkgs/development/tools/electron-fiddle/default.nix index 4add8cadb7d3..cde2dcae311c 100644 --- a/pkgs/development/tools/electron-fiddle/default.nix +++ b/pkgs/development/tools/electron-fiddle/default.nix @@ -61,7 +61,7 @@ let patchShebangs node_modules mkdir -p ~/.cache/electron/${electronDummyHash} - cp -ra '${electron}/libexec/electron' "$TMPDIR/electron" + cp -ra '${electron.dist}' "$TMPDIR/electron" chmod -R u+w "$TMPDIR/electron" (cd "$TMPDIR/electron" && zip -0Xr ~/.cache/electron/${electronDummyHash}/${electronDummyFilename} .) From 7dc03bea932a318fe33edcac6b3f327ad913b026 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:12:24 +0200 Subject: [PATCH 10/23] feishin: use electron.dist --- pkgs/by-name/fe/feishin/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/fe/feishin/package.nix b/pkgs/by-name/fe/feishin/package.nix index b0c1d682f305..8b4c8d8aac1e 100644 --- a/pkgs/by-name/fe/feishin/package.nix +++ b/pkgs/by-name/fe/feishin/package.nix @@ -79,7 +79,7 @@ buildNpmPackage { postBuild = lib.optionalString stdenv.isDarwin '' # electron-builder appears to build directly on top of Electron.app, by overwriting the files in the bundle. - cp -r ${electron}/Applications/Electron.app ./ + cp -r ${electron.dist}/Electron.app ./ find ./Electron.app -name 'Info.plist' | xargs -d '\n' chmod +rw # Disable code signing during build on macOS. @@ -90,7 +90,7 @@ buildNpmPackage { + '' npm exec electron-builder -- \ --dir \ - -c.electronDist=${if stdenv.isDarwin then "./" else "${electron}/libexec/electron"} \ + -c.electronDist=${if stdenv.isDarwin then "./" else electron.dist} \ -c.electronVersion=${electron.version} \ -c.npmRebuild=false ''; From ba8d750a413665179d7088507f5fb8b96d3ce574 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Mon, 12 Aug 2024 22:27:30 +0200 Subject: [PATCH 11/23] goofcord: use electron.dist --- pkgs/by-name/go/goofcord/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/go/goofcord/package.nix b/pkgs/by-name/go/goofcord/package.nix index fe510af719e0..14fe785c499a 100644 --- a/pkgs/by-name/go/goofcord/package.nix +++ b/pkgs/by-name/go/goofcord/package.nix @@ -56,7 +56,7 @@ stdenv.mkDerivation (finalAttrs: { npm exec electron-builder -- \ --dir \ - -c.electronDist="${electron}/libexec/electron" \ + -c.electronDist="${electron.dist}" \ -c.electronVersion="${electron.version}" runHook postBuild From 5eb0921fb2540ab7f2f42b22534e1657bf4a09df Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Sun, 2 Jun 2024 19:11:12 +0200 Subject: [PATCH 12/23] jisti-meet-electron: use electron.dist --- .../instant-messengers/jitsi-meet-electron/default.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/applications/networking/instant-messengers/jitsi-meet-electron/default.nix b/pkgs/applications/networking/instant-messengers/jitsi-meet-electron/default.nix index 78c6912b12ba..7d0044c7124c 100644 --- a/pkgs/applications/networking/instant-messengers/jitsi-meet-electron/default.nix +++ b/pkgs/applications/networking/instant-messengers/jitsi-meet-electron/default.nix @@ -16,8 +16,6 @@ let inherit (darwin.apple_sdk.frameworks) Carbon CoreFoundation ApplicationServices OpenGL; - - electronDist = electron + (if stdenv.isDarwin then "/Applications" else "/libexec/electron"); in buildNpmPackage rec { pname = "jitsi-meet-electron"; @@ -70,7 +68,7 @@ buildNpmPackage rec { ''; postBuild = '' - cp -r ${electronDist} electron-dist + cp -r ${electron.dist} electron-dist chmod -R u+w electron-dist # npmRebuild is needed because robotjs won't be built on darwin otherwise From f732bff33adecf52db6acabb72267ab7c32e87b7 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Mon, 12 Aug 2024 21:58:57 +0200 Subject: [PATCH 13/23] koodo-reader: use electron.dist --- pkgs/by-name/ko/koodo-reader/package.nix | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/ko/koodo-reader/package.nix b/pkgs/by-name/ko/koodo-reader/package.nix index 9fa8ce626b9a..a57c44b0c37f 100644 --- a/pkgs/by-name/ko/koodo-reader/package.nix +++ b/pkgs/by-name/ko/koodo-reader/package.nix @@ -13,9 +13,6 @@ electron, }: -let - electronDist = electron + (if stdenv.isDarwin then "/Applications" else "/libexec/electron"); -in stdenv.mkDerivation (finalAttrs: { pname = "koodo-reader"; version = "1.6.7"; @@ -52,7 +49,7 @@ stdenv.mkDerivation (finalAttrs: { env.CSC_IDENTITY_AUTO_DISCOVERY = "false"; postBuild = '' - cp -r ${electronDist} electron-dist + cp -r ${electron.dist} electron-dist chmod -R u+w electron-dist yarn --offline run electron-builder --dir \ -c.electronDist=electron-dist \ @@ -117,7 +114,7 @@ stdenv.mkDerivation (finalAttrs: { meta = { changelog = "https://github.com/troyeguo/koodo-reader/releases/tag/v${finalAttrs.version}"; - description = "A cross-platform ebook reader"; + description = "Cross-platform ebook reader"; longDescription = '' A modern ebook manager and reader with sync and backup capacities for Windows, macOS, Linux and Web From 92030d526d40e45997b890760a8e4a016ad5fed9 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Mon, 12 Aug 2024 22:16:32 +0200 Subject: [PATCH 14/23] kuro: use electron.dist --- pkgs/applications/misc/kuro/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/misc/kuro/default.nix b/pkgs/applications/misc/kuro/default.nix index 02911f312122..e0240b38afec 100644 --- a/pkgs/applications/misc/kuro/default.nix +++ b/pkgs/applications/misc/kuro/default.nix @@ -43,7 +43,7 @@ stdenv.mkDerivation rec { yarnBuildScript = "electron-builder"; yarnBuildFlags = [ "--dir" - "-c.electronDist=${electron}/libexec/electron" + "-c.electronDist=${electron.dist}" "-c.electronVersion=${electron.version}" ]; From e436eb9dfa365926af9d0d7aa84b00f64a462d7d Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Mon, 12 Aug 2024 22:19:56 +0200 Subject: [PATCH 15/23] mqtt-explorer: use electron.dist --- pkgs/by-name/mq/mqtt-explorer/package.nix | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pkgs/by-name/mq/mqtt-explorer/package.nix b/pkgs/by-name/mq/mqtt-explorer/package.nix index 2b15225fb037..dec432204622 100644 --- a/pkgs/by-name/mq/mqtt-explorer/package.nix +++ b/pkgs/by-name/mq/mqtt-explorer/package.nix @@ -12,9 +12,6 @@ makeDesktopItem, copyDesktopItems, }: -let - electronDist = electron + (if stdenv.isDarwin then "/Applications" else "/libexec/electron"); -in # NOTE mqtt-explorer has 3 yarn subpackages and uses relative links # between them, which makes it hard to package them via 3 `mkYarnPackage` # since the resulting `node_modules` directories don't have the same structure @@ -88,7 +85,7 @@ stdenv.mkDerivation rec { patchShebangs {node_modules,app/node_modules,backend/node_modules} - cp -r ${electronDist} electron-dist + cp -r ${electron.dist} electron-dist chmod -R u+w electron-dist runHook postConfigure From bc04f75308f3adc6292a68f96afcedb32ca66128 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:14:16 +0200 Subject: [PATCH 16/23] podman-desktop: use electron.dist --- pkgs/applications/virtualization/podman-desktop/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/virtualization/podman-desktop/default.nix b/pkgs/applications/virtualization/podman-desktop/default.nix index fdf829401399..015768b4ed7c 100644 --- a/pkgs/applications/virtualization/podman-desktop/default.nix +++ b/pkgs/applications/virtualization/podman-desktop/default.nix @@ -73,7 +73,7 @@ stdenv.mkDerivation (finalAttrs: { yarn --offline run build yarn --offline run electron-builder --dir \ --config .electron-builder.config.cjs \ - -c.electronDist=${electron}/libexec/electron \ + -c.electronDist=${electron.dist} \ -c.electronVersion=${electron.version} runHook postBuild From ac6d5c83107578817bb1dfaa7f34fa5405f7ed93 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:17:01 +0200 Subject: [PATCH 17/23] redisinsight: use electron.dist --- pkgs/development/tools/redisinsight/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/tools/redisinsight/default.nix b/pkgs/development/tools/redisinsight/default.nix index 1ea9f69241a6..3889022daf97 100644 --- a/pkgs/development/tools/redisinsight/default.nix +++ b/pkgs/development/tools/redisinsight/default.nix @@ -116,7 +116,7 @@ stdenv.mkDerivation (finalAttrs: { yarn --offline electron-builder \ --dir \ - -c.electronDist=${electron}/libexec/electron \ + -c.electronDist=${electron.dist} \ -c.electronVersion=${electron.version} runHook postBuild From d29486120da6b24b370bbed7300b4791f2234e6e Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:16:06 +0200 Subject: [PATCH 18/23] ride: use electron.dist --- pkgs/by-name/ri/ride/package.nix | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/by-name/ri/ride/package.nix b/pkgs/by-name/ri/ride/package.nix index 0cce0041710a..9706b388dbf7 100644 --- a/pkgs/by-name/ri/ride/package.nix +++ b/pkgs/by-name/ri/ride/package.nix @@ -32,8 +32,6 @@ let }; platformInfo = platformInfos.${stdenv.system}; - - electronDist = electron + (if stdenv.isDarwin then "/Applications" else "/libexec/electron"); in buildNpmPackage rec { pname = "ride"; @@ -109,7 +107,7 @@ buildNpmPackage rec { mkdir local-cache # electron files need to be writable on Darwin - cp -r ${electronDist} electron-dist + cp -r ${electron.dist} electron-dist chmod -R u+w electron-dist pushd electron-dist From ad6a87de8cdb5a7edeb907812496f1b0da182bfe Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Mon, 12 Aug 2024 22:01:10 +0200 Subject: [PATCH 19/23] siyuan: use electron.dist --- pkgs/by-name/si/siyuan/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/si/siyuan/package.nix b/pkgs/by-name/si/siyuan/package.nix index 1059a5726439..52b3c68ffc73 100644 --- a/pkgs/by-name/si/siyuan/package.nix +++ b/pkgs/by-name/si/siyuan/package.nix @@ -101,7 +101,7 @@ stdenv.mkDerivation (finalAttrs: { npm exec electron-builder -- \ --dir \ --config electron-builder-${platformId}.yml \ - -c.electronDist=${electron}/libexec/electron \ + -c.electronDist=${electron.dist} \ -c.electronVersion=${electron.version} runHook postBuild From 6cfd1daffbc9dd3acb64e9314bc7fb866d21ae67 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:14:05 +0200 Subject: [PATCH 20/23] teams-for-linux: use electron.dist --- .../networking/instant-messengers/teams-for-linux/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/instant-messengers/teams-for-linux/default.nix b/pkgs/applications/networking/instant-messengers/teams-for-linux/default.nix index b5ac402921d2..f0822605627b 100644 --- a/pkgs/applications/networking/instant-messengers/teams-for-linux/default.nix +++ b/pkgs/applications/networking/instant-messengers/teams-for-linux/default.nix @@ -50,7 +50,7 @@ stdenv.mkDerivation (finalAttrs: { yarn --offline electron-builder \ --dir ${if stdenv.isDarwin then "--macos" else "--linux"} ${if stdenv.hostPlatform.isAarch64 then "--arm64" else "--x64"} \ - -c.electronDist=${electron}/libexec/electron \ + -c.electronDist=${electron.dist} \ -c.electronVersion=${electron.version} runHook postBuild From 1fad8f346386acf47276d1fae575bd4cc78af6b1 Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:16:38 +0200 Subject: [PATCH 21/23] vesktop: use electron.dist --- pkgs/by-name/ve/vesktop/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/ve/vesktop/package.nix b/pkgs/by-name/ve/vesktop/package.nix index f1a310c3a833..6d65fe99d89a 100644 --- a/pkgs/by-name/ve/vesktop/package.nix +++ b/pkgs/by-name/ve/vesktop/package.nix @@ -87,7 +87,7 @@ stdenv.mkDerivation (finalAttrs: { # electron builds must be writable on darwin preBuild = lib.optionalString stdenv.isDarwin '' - cp -r ${electron}/Applications/Electron.app . + cp -r ${electron.dist}/Electron.app . chmod -R u+w Electron.app ''; @@ -98,7 +98,7 @@ stdenv.mkDerivation (finalAttrs: { pnpm exec electron-builder \ --dir \ -c.asarUnpack="**/*.node" \ - -c.electronDist=${if stdenv.isDarwin then "." else "${electron}/libexec/electron"} \ + -c.electronDist=${if stdenv.isDarwin then "." else electron.dist} \ -c.electronVersion=${electron.version} runHook postBuild From 59e6851f58f1c23729a6b9760f5b7d34e20b060f Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:13:31 +0200 Subject: [PATCH 22/23] whalebird: use electron.dist --- pkgs/applications/misc/whalebird/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/misc/whalebird/default.nix b/pkgs/applications/misc/whalebird/default.nix index 15bd937506ee..e46a1af85c82 100644 --- a/pkgs/applications/misc/whalebird/default.nix +++ b/pkgs/applications/misc/whalebird/default.nix @@ -73,7 +73,7 @@ stdenv.mkDerivation rec { yarn run nextron build --no-pack yarn run electron-builder --dir \ --config electron-builder.yml \ - -c.electronDist="${electron}/libexec/electron" \ + -c.electronDist="${electron.dist}" \ -c.electronVersion=${electron.version} runHook postBuild From e97d8f7ed830b4e41dad9e28344da4deafdc098d Mon Sep 17 00:00:00 2001 From: TomaSajt <62384384+TomaSajt@users.noreply.github.com> Date: Tue, 21 May 2024 19:12:38 +0200 Subject: [PATCH 23/23] youtube-music: use electron.dist --- pkgs/applications/audio/youtube-music/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/audio/youtube-music/default.nix b/pkgs/applications/audio/youtube-music/default.nix index 7d639ba3a5cc..59d33a00511b 100644 --- a/pkgs/applications/audio/youtube-music/default.nix +++ b/pkgs/applications/audio/youtube-music/default.nix @@ -33,13 +33,13 @@ stdenv.mkDerivation (finalAttrs: { ELECTRON_SKIP_BINARY_DOWNLOAD = 1; postBuild = lib.optionalString stdenv.isDarwin '' - cp -R ${electron}/Applications/Electron.app Electron.app + cp -R ${electron.dist}/Electron.app Electron.app chmod -R u+w Electron.app '' + '' pnpm build ./node_modules/.bin/electron-builder \ --dir \ - -c.electronDist=${if stdenv.isDarwin then "." else "${electron}/libexec/electron"} \ + -c.electronDist=${if stdenv.isDarwin then "." else electron.dist} \ -c.electronVersion=${electron.version} '';