From c8d955a497ed269aad6b7123689acbb387154b87 Mon Sep 17 00:00:00 2001 From: kpbaks Date: Thu, 30 Oct 2025 19:18:49 +0100 Subject: [PATCH 1/3] kompose: switch to finalAttrs form --- pkgs/by-name/ko/kompose/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/ko/kompose/package.nix b/pkgs/by-name/ko/kompose/package.nix index f3873a5fd794..35405c3641f6 100644 --- a/pkgs/by-name/ko/kompose/package.nix +++ b/pkgs/by-name/ko/kompose/package.nix @@ -8,14 +8,14 @@ git, }: -buildGoModule rec { +buildGoModule (finalAttrs: { pname = "kompose"; version = "1.37.0"; src = fetchFromGitHub { owner = "kubernetes"; repo = "kompose"; - rev = "v${version}"; + tag = "v${finalAttrs.version}"; hash = "sha256-wS9YoYEsCALIJMxoVTS6EH6NiBfF+qkFIv7JALnVPgs="; }; @@ -55,4 +55,4 @@ buildGoModule rec { vdemeester ]; }; -} +}) From 6ec725f40ceef841c8e3c8bd92eabb3db7288e3a Mon Sep 17 00:00:00 2001 From: kpbaks Date: Thu, 30 Oct 2025 19:19:20 +0100 Subject: [PATCH 2/3] kompose: add meta.changelog --- pkgs/by-name/ko/kompose/package.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/by-name/ko/kompose/package.nix b/pkgs/by-name/ko/kompose/package.nix index 35405c3641f6..45e6de428110 100644 --- a/pkgs/by-name/ko/kompose/package.nix +++ b/pkgs/by-name/ko/kompose/package.nix @@ -49,6 +49,7 @@ buildGoModule (finalAttrs: { description = "Tool to help users who are familiar with docker-compose move to Kubernetes"; mainProgram = "kompose"; homepage = "https://kompose.io"; + changelog = "https://github.com/kubernetes/kompose/releases/tag/${finalAttrs.src.tag}"; license = licenses.asl20; maintainers = with maintainers; [ thpham From 5a60c1b199b756d633255f24a848c4a8b5c7a461 Mon Sep 17 00:00:00 2001 From: kpbaks Date: Thu, 30 Oct 2025 19:19:30 +0100 Subject: [PATCH 3/3] kompose: install fish shell completions --- pkgs/by-name/ko/kompose/package.nix | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/ko/kompose/package.nix b/pkgs/by-name/ko/kompose/package.nix index 45e6de428110..ed23efe96c56 100644 --- a/pkgs/by-name/ko/kompose/package.nix +++ b/pkgs/by-name/ko/kompose/package.nix @@ -1,5 +1,6 @@ { lib, + stdenv, buildGoModule, fetchFromGitHub, installShellFiles, @@ -33,11 +34,11 @@ buildGoModule (finalAttrs: { checkFlags = [ "-short" ]; - postInstall = '' - for shell in bash zsh; do - $out/bin/kompose completion $shell > kompose.$shell - installShellCompletion kompose.$shell - done + postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) '' + installShellCompletion --cmd ${finalAttrs.meta.mainProgram} \ + --bash <($out/bin/${finalAttrs.meta.mainProgram} completion bash) \ + --zsh <($out/bin/${finalAttrs.meta.mainProgram} completion zsh) \ + --fish <($out/bin/${finalAttrs.meta.mainProgram} completion fish) ''; passthru.tests.version = testers.testVersion {