From efe94e09427f20b387bf65d58ee574643842d868 Mon Sep 17 00:00:00 2001 From: Aliaksandr Date: Tue, 10 Feb 2026 03:45:21 +0200 Subject: [PATCH] mkgmap-splitter: use SRI hashes and finalAttrs pattern --- pkgs/by-name/mk/mkgmap-splitter/package.nix | 62 +++++++++---------- .../by-name/mk/mkgmap-splitter/testinputs.nix | 8 +-- 2 files changed, 35 insertions(+), 35 deletions(-) diff --git a/pkgs/by-name/mk/mkgmap-splitter/package.nix b/pkgs/by-name/mk/mkgmap-splitter/package.nix index a006edcc0e4e..67adcb1b10be 100644 --- a/pkgs/by-name/mk/mkgmap-splitter/package.nix +++ b/pkgs/by-name/mk/mkgmap-splitter/package.nix @@ -7,21 +7,23 @@ jre, ant, makeWrapper, + mkgmap, stripJavaArchivesHook, doCheck ? true, }: + let - deps = import ../deps.nix { inherit fetchurl; }; + inherit (mkgmap) deps; testInputs = import ./testinputs.nix { inherit fetchurl; }; in -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "splitter"; version = "654"; src = fetchsvn { url = "https://svn.mkgmap.org.uk/mkgmap/splitter/trunk"; - rev = version; - sha256 = "sha256-y/pl8kIQ6fiF541ho72LMgJFWJdkUBqPToQGCGmmcfg="; + rev = finalAttrs.version; + hash = "sha256-y/pl8kIQ6fiF541ho72LMgJFWJdkUBqPToQGCGmmcfg="; }; patches = [ @@ -31,33 +33,31 @@ stdenv.mkDerivation rec { ./fix-failing-test.patch ]; - postPatch = - with deps; - '' - # Manually create version properties file for reproducibility - mkdir -p build/classes - cat > build/classes/splitter-version.properties << EOF - svn.version=${version} - build.timestamp=unknown - EOF + postPatch = '' + # Manually create version properties file for reproducibility + mkdir -p build/classes + cat > build/classes/splitter-version.properties << EOF + svn.version=${finalAttrs.version} + build.timestamp=unknown + EOF - # Put pre-fetched dependencies into the right place - mkdir -p lib/compile - cp ${fastutil} lib/compile/${fastutil.name} - cp ${osmpbf} lib/compile/${osmpbf.name} - cp ${protobuf} lib/compile/${protobuf.name} - cp ${xpp3} lib/compile/${xpp3.name} - '' - + lib.optionalString doCheck '' - mkdir -p lib/test - cp ${junit} lib/test/${junit.name} - cp ${hamcrest-core} lib/test/${hamcrest-core.name} + # Put pre-fetched dependencies into the right place + mkdir -p lib/compile + cp ${deps.fastutil} lib/compile/${deps.fastutil.name} + cp ${deps.osmpbf} lib/compile/${deps.osmpbf.name} + cp ${deps.protobuf} lib/compile/${deps.protobuf.name} + cp ${deps.xpp3} lib/compile/${deps.xpp3.name} + '' + + lib.optionalString doCheck '' + mkdir -p lib/test + cp ${deps.junit} lib/test/${deps.junit.name} + cp ${deps.hamcrest-core} lib/test/${deps.hamcrest-core.name} - mkdir -p test/resources/in/osm - ${lib.concatMapStringsSep "\n" (res: '' - cp ${res} test/resources/in/${builtins.replaceStrings [ "__" ] [ "/" ] res.name} - '') testInputs} - ''; + mkdir -p test/resources/in/osm + ${lib.concatMapStringsSep "\n" (res: '' + cp ${res} test/resources/in/${builtins.replaceStrings [ "__" ] [ "/" ] res.name} + '') testInputs} + ''; nativeBuildInputs = [ jdk @@ -96,7 +96,7 @@ stdenv.mkDerivation rec { passthru.updateScript = [ ./update.sh "mkgmap-splitter" - meta.downloadPage + finalAttrs.meta.downloadPage ]; meta = { @@ -112,4 +112,4 @@ stdenv.mkDerivation rec { binaryBytecode # deps ]; }; -} +}) diff --git a/pkgs/by-name/mk/mkgmap-splitter/testinputs.nix b/pkgs/by-name/mk/mkgmap-splitter/testinputs.nix index 462e8bfa0beb..9b0a74730fd1 100644 --- a/pkgs/by-name/mk/mkgmap-splitter/testinputs.nix +++ b/pkgs/by-name/mk/mkgmap-splitter/testinputs.nix @@ -1,9 +1,9 @@ { fetchurl }: let fetchTestInput = - { res, sha256 }: + { res, hash }: fetchurl { - inherit sha256; + inherit hash; url = "https://www.mkgmap.org.uk/testinput/${res}"; name = builtins.replaceStrings [ "/" ] [ "__" ] res; }; @@ -11,10 +11,10 @@ in [ (fetchTestInput { res = "osm/alaska-2016-12-27.osm.pbf"; - sha256 = "0hmb5v71a1bxgvrg1cbfj5l27b3vvdazs4pyggpmhcdhbwpw7ppm"; + hash = "sha256-9d7DL1+wMVjve/4S/VXbe6wjaJFusfDyfn0FFc4uq0I="; }) (fetchTestInput { res = "osm/hamburg-2016-12-26.osm.pbf"; - sha256 = "08bny4aavwm3z2114q99fv3fi2w905zxi0fl7bqgjyhgk0fxjssf"; + hash = "sha256-TmvZHZgPevnwOtSB2H8BiYvoxnYpYRKC+KPyrRTxdiE="; }) ]