From c8c2d706a538cfdec2d6793d7a75bd400a4a01a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Hamb=C3=BCchen?= Date: Fri, 7 Nov 2025 16:23:18 +0000 Subject: [PATCH 1/2] moonfire-nvr: Fix unstable UI path. See https://github.com/NixOS/nixpkgs/pull/243261#pullrequestreview-1793813904 Fixes the symlink from being e.g. /nix/store/c0v8rfg69c042ck81vbmfhqgmlsbp2jd-moonfire-nvr-0.7.7/lib/ui/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7 -> /nix/store/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7/ to being /nix/store/c0v8rfg69c042ck81vbmfhqgmlsbp2jd-moonfire-nvr-0.7.7/lib/ui -> /nix/store/n9c8ijzh0ndgp6s5h88ix41wfhfxycpz-moonfire-nvr-ui-0.7.7/ Most likely this was caused by a misunderstanding of how `ln -s target linkname` works: If the `linkname` already exists and is a directory, it creates the link _inside_ it, with the link's filename being the basename of `target`. --- pkgs/by-name/mo/moonfire-nvr/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/mo/moonfire-nvr/package.nix b/pkgs/by-name/mo/moonfire-nvr/package.nix index 6ea4fd50c06d..f01c61d8cbd8 100644 --- a/pkgs/by-name/mo/moonfire-nvr/package.nix +++ b/pkgs/by-name/mo/moonfire-nvr/package.nix @@ -63,7 +63,7 @@ rustPlatform.buildRustPackage { ]; postInstall = '' - mkdir -p $out/lib/ui + mkdir -p $out/lib ln -s ${ui} $out/lib/ui ''; From 8113ae6d734910e12cfa21ae491b529773293ee0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niklas=20Hamb=C3=BCchen?= Date: Fri, 7 Nov 2025 16:34:05 +0000 Subject: [PATCH 2/2] moonnfire-nvr: Fix incorrect testVersion invocation --- pkgs/by-name/mo/moonfire-nvr/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/mo/moonfire-nvr/package.nix b/pkgs/by-name/mo/moonfire-nvr/package.nix index f01c61d8cbd8..ee6f608a6493 100644 --- a/pkgs/by-name/mo/moonfire-nvr/package.nix +++ b/pkgs/by-name/mo/moonfire-nvr/package.nix @@ -72,9 +72,9 @@ rustPlatform.buildRustPackage { passthru = { inherit ui; tests.version = testers.testVersion { - inherit version; package = moonfire-nvr; command = "moonfire-nvr --version"; + version = "Version: v${version}"; }; };