From ef2c135062257b38aa03cb8aad8c39bd7fad1871 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Tue, 19 Aug 2025 10:28:20 -0700 Subject: [PATCH] python3Packages.chromadb: disable integration and distributed tests --- .../python-modules/chromadb/default.nix | 10 +++------- .../chromadb/disable-fastapi-fixtures.patch | 14 -------------- 2 files changed, 3 insertions(+), 21 deletions(-) delete mode 100644 pkgs/development/python-modules/chromadb/disable-fastapi-fixtures.patch diff --git a/pkgs/development/python-modules/chromadb/default.nix b/pkgs/development/python-modules/chromadb/default.nix index 4a351addae9e..eaaa7ab4bbac 100644 --- a/pkgs/development/python-modules/chromadb/default.nix +++ b/pkgs/development/python-modules/chromadb/default.nix @@ -88,11 +88,6 @@ buildPythonPackage rec { hash = "sha256-H+kXxA/6rKzYA19v7Zlx2HbIg/DGicD5FDIs0noVGSk="; }; - patches = [ - # The fastapi servers can't set up their networking in the test environment, so disable for testing - ./disable-fastapi-fixtures.patch - ]; - postPatch = '' # Nixpkgs is taking the version from `chromadb_rust_bindings` which is versioned independently substituteInPlace pyproject.toml \ @@ -188,9 +183,12 @@ buildPythonPackage rec { "-Wignore:PytestCollectionWarning" ]; + # Skip the distributed and integration tests + # See https://github.com/chroma-core/chroma/issues/5315 preCheck = '' (($(ulimit -n) < 1024)) && ulimit -n 1024 export HOME=$(mktemp -d) + export CHROMA_RUST_BINDINGS_TEST_ONLY=1 ''; disabledTests = [ @@ -209,8 +207,6 @@ buildPythonPackage rec { "test_collection_query_with_invalid_collection_throws" "test_collection_update_with_invalid_collection_throws" "test_default_embedding" - "test_invalid_index_params" - "test_peek" "test_persist_index_loading" "test_query_id_filtering_e2e" "test_query_id_filtering_medium_dataset" diff --git a/pkgs/development/python-modules/chromadb/disable-fastapi-fixtures.patch b/pkgs/development/python-modules/chromadb/disable-fastapi-fixtures.patch deleted file mode 100644 index 7c63ced3cf95..000000000000 --- a/pkgs/development/python-modules/chromadb/disable-fastapi-fixtures.patch +++ /dev/null @@ -1,14 +0,0 @@ -diff --git a/chromadb/test/conftest.py b/chromadb/test/conftest.py -index efde1c382..163f55c57 100644 ---- a/chromadb/test/conftest.py -+++ b/chromadb/test/conftest.py -@@ -678,9 +678,6 @@ def sqlite_persistent(request: pytest.FixtureRequest) -> Generator[System, None, - - def system_fixtures() -> List[Callable[[], Generator[System, None, None]]]: - fixtures = [ -- fastapi, -- async_fastapi, -- fastapi_persistent, - sqlite_fixture, - sqlite_persistent_fixture, - ]