From aeae82eb6b4e2e423791eb2b15618383a5a11264 Mon Sep 17 00:00:00 2001 From: rucadi Date: Thu, 28 Mar 2024 19:41:21 +0100 Subject: [PATCH 1/2] Revert "nodejs_18: 18.19.1 -> 18.20.0" This reverts commit b5e930a583294d194f3ba807283552b25f8a2888. --- pkgs/development/web/nodejs/v18.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/web/nodejs/v18.nix b/pkgs/development/web/nodejs/v18.nix index 3fffdf909e6c..bc86d6c89dbd 100644 --- a/pkgs/development/web/nodejs/v18.nix +++ b/pkgs/development/web/nodejs/v18.nix @@ -19,8 +19,8 @@ let in buildNodejs { inherit enableNpm; - version = "18.20.0"; - sha256 = "sha256-BMhneaLMfu/fzzeanYWIOqHTsdyJCbYiGxY2hIF4VqQ="; + version = "18.19.1"; + sha256 = "sha256-CQ+WouzeCAtrOCxtZCvKXQvkcCp4y1Vb578CsgvRbe0="; patches = [ ./disable-darwin-v8-system-instrumentation.patch ./bypass-darwin-xcrun-node16.patch From 49adc35edc6af66d789c1399cd9c6452a4761fd2 Mon Sep 17 00:00:00 2001 From: Rucadi Date: Thu, 28 Mar 2024 23:23:15 +0100 Subject: [PATCH 2/2] nodejs_18: Add comment to warn about ffi-napi compatibility problem to prevent updating to newer versions. --- pkgs/development/web/nodejs/v18.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/development/web/nodejs/v18.nix b/pkgs/development/web/nodejs/v18.nix index bc86d6c89dbd..a4121b9575fd 100644 --- a/pkgs/development/web/nodejs/v18.nix +++ b/pkgs/development/web/nodejs/v18.nix @@ -19,6 +19,9 @@ let in buildNodejs { inherit enableNpm; + # The change to minor version 18.20.0 breaks compatibility with ffi-napi + # This breaks the compilation of some nix packages. + # While this is investigated and fixed, do not upgrade the minor version. version = "18.19.1"; sha256 = "sha256-CQ+WouzeCAtrOCxtZCvKXQvkcCp4y1Vb578CsgvRbe0="; patches = [