From ee0e3fb5405c655fba5162a660340d4a8cdd0d57 Mon Sep 17 00:00:00 2001 From: Someone Serge Date: Fri, 26 Jul 2024 16:30:09 +0000 Subject: [PATCH] faiss: disable the demo (cuda version fails at linkage) --- .../libraries/science/math/faiss/default.nix | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/pkgs/development/libraries/science/math/faiss/default.nix b/pkgs/development/libraries/science/math/faiss/default.nix index 3e1b9f1536d0..4ee0112337e8 100644 --- a/pkgs/development/libraries/science/math/faiss/default.nix +++ b/pkgs/development/libraries/science/math/faiss/default.nix @@ -97,12 +97,14 @@ stdenv.mkDerivation { "-DCMAKE_CUDA_ARCHITECTURES=${flags.cmakeCudaArchitecturesString}" ]; - buildFlags = [ - "faiss" - "demo_ivfpq_indexing" - ] ++ lib.optionals pythonSupport [ - "swigfaiss" - ]; + + buildFlags = + [ "faiss" ] + # This is just a demo app used as a test. + # Disabled because linkage fails: + # https://github.com/facebookresearch/faiss/issues/3484 + ++ lib.optionals (!cudaSupport) [ "demo_ivfpq_indexing" ] + ++ lib.optionals pythonSupport [ "swigfaiss" ]; # pip wheel->pip install commands copied over from opencv4 @@ -113,7 +115,9 @@ stdenv.mkDerivation { postInstall = '' mkdir -p $demos/bin - cp ./demos/demo_ivfpq_indexing $demos/bin/ + if [[ "$buildInputs" == *demo_ivfpq_indexing* ]] ; then + cp ./demos/demo_ivfpq_indexing $demos/bin/ + fi '' + lib.optionalString pythonSupport '' mkdir -p $out/${pythonPackages.python.sitePackages} (cd faiss/python && python -m pip install dist/*.whl --no-index --no-warn-script-location --prefix="$out" --no-cache)