From aaa57eda49d105e9b961b1e2cb288740d6e3e837 Mon Sep 17 00:00:00 2001 From: Jonathan Davies Date: Thu, 6 Nov 2025 21:40:59 +0000 Subject: [PATCH 1/3] temporal: Add versionCheckHook --- pkgs/by-name/te/temporal/package.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/by-name/te/temporal/package.nix b/pkgs/by-name/te/temporal/package.nix index f2cc1a5cc3ec..db2982655dda 100644 --- a/pkgs/by-name/te/temporal/package.nix +++ b/pkgs/by-name/te/temporal/package.nix @@ -5,6 +5,7 @@ nixosTests, testers, temporal, + versionCheckHook, }: buildGoModule rec { @@ -47,6 +48,12 @@ buildGoModule rec { runHook postInstall ''; + nativeInstallCheckInputs = [ + versionCheckHook + ]; + versionCheckProgramArg = "--version"; + doInstallCheck = true; + passthru.tests = { inherit (nixosTests) temporal; version = testers.testVersion { From 1b2df5ad996dfb21703f2ee3fbc2cd70c5edee94 Mon Sep 17 00:00:00 2001 From: Jonathan Davies Date: Sun, 14 Dec 2025 22:19:46 +0000 Subject: [PATCH 2/3] temporal: Add patch to fix Darwin panic for versionCheckHook --- .../te/temporal/darwin-sandbox-fix.patch | 20 +++++++++++++++++++ pkgs/by-name/te/temporal/package.nix | 9 ++++++++- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 pkgs/by-name/te/temporal/darwin-sandbox-fix.patch diff --git a/pkgs/by-name/te/temporal/darwin-sandbox-fix.patch b/pkgs/by-name/te/temporal/darwin-sandbox-fix.patch new file mode 100644 index 000000000000..b390d492467c --- /dev/null +++ b/pkgs/by-name/te/temporal/darwin-sandbox-fix.patch @@ -0,0 +1,20 @@ +--- vendor/modernc.org/libc/honnef.co/go/netdb/netdb.go ++++ vendor/modernc.org/libc/honnef.co/go/netdb/netdb.go +@@ -696,7 +696,7 @@ func init() { + // Load protocols + data, err := ioutil.ReadFile("/etc/protocols") + if err != nil { +- if !os.IsNotExist(err) { ++ if !os.IsNotExist(err) && !os.IsPermission(err) { + panic(err) + } + +@@ -732,7 +732,7 @@ func init() { + // Load services + data, err = ioutil.ReadFile("/etc/services") + if err != nil { +- if !os.IsNotExist(err) { ++ if !os.IsNotExist(err) && !os.IsPermission(err) { + panic(err) + } + diff --git a/pkgs/by-name/te/temporal/package.nix b/pkgs/by-name/te/temporal/package.nix index db2982655dda..2641f2b1f849 100644 --- a/pkgs/by-name/te/temporal/package.nix +++ b/pkgs/by-name/te/temporal/package.nix @@ -19,7 +19,14 @@ buildGoModule rec { hash = "sha256-WiiezZ/2FgRte4BStIGHQhb5bHtfldi3TaIRG0xFtW0="; }; - vendorHash = "sha256-HW2j8swbaWwU1i3udqlT8VyFreML6ZH14zWxF8L5NTQ="; + vendorHash = "sha256-CdzcOE/J0gqUbq7BXPpLFyNPNbFTziR5j9GPdYPzv50="; + + overrideModAttrs = old: { + # netdb.go allows /etc/protocols and /etc/services to not exist and happily proceeds, but it panic()s if they exist but return permission denied. + postBuild = '' + patch -p0 < ${./darwin-sandbox-fix.patch} + ''; + }; excludedPackages = [ "./build" ]; From b604e6effdaa260fc3f72667443785d5d011e774 Mon Sep 17 00:00:00 2001 From: Jonathan Davies Date: Sun, 14 Dec 2025 22:21:11 +0000 Subject: [PATCH 3/3] temporal: Use finalAttrs --- pkgs/by-name/te/temporal/package.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/by-name/te/temporal/package.nix b/pkgs/by-name/te/temporal/package.nix index 2641f2b1f849..c754df508f40 100644 --- a/pkgs/by-name/te/temporal/package.nix +++ b/pkgs/by-name/te/temporal/package.nix @@ -8,14 +8,14 @@ versionCheckHook, }: -buildGoModule rec { +buildGoModule (finalAttrs: { pname = "temporal"; version = "1.29.2"; src = fetchFromGitHub { owner = "temporalio"; repo = "temporal"; - rev = "v${version}"; + tag = "v${finalAttrs.version}"; hash = "sha256-WiiezZ/2FgRte4BStIGHQhb5bHtfldi3TaIRG0xFtW0="; }; @@ -71,9 +71,9 @@ buildGoModule rec { meta = { description = "Microservice orchestration platform which enables developers to build scalable applications without sacrificing productivity or reliability"; homepage = "https://temporal.io"; - changelog = "https://github.com/temporalio/temporal/releases/tag/v${version}"; + changelog = "https://github.com/temporalio/temporal/releases/tag/v${finalAttrs.version}"; license = lib.licenses.mit; maintainers = with lib.maintainers; [ jpds ]; mainProgram = "temporal-server"; }; -} +})