From e61a2da3885cf5846476b643152cedc86516d802 Mon Sep 17 00:00:00 2001 From: Victor Engmark Date: Fri, 9 Jun 2023 10:29:14 +1200 Subject: [PATCH] nixos-rebuild: Fix ShellCheck issue ShellCheck recommends splitting this into `mkdir` + `chmod`, but based on the discussion with @bjornfor in #357447 it's probably better to keep the atomic directory creation and the probable intent of the original code. --- pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh b/pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh index 43d5653156cb..9e4fde59172c 100755 --- a/pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh +++ b/pkgs/os-specific/linux/nixos-rebuild/nixos-rebuild.sh @@ -141,7 +141,7 @@ while [ "$#" -gt 0 ]; do fi if [ "$1" != system ]; then profile="/nix/var/nix/profiles/system-profiles/$1" - mkdir -p -m 0755 "$(dirname "$profile")" + (umask 022 && mkdir -p "$(dirname "$profile")") fi shift 1 ;;